[Reporting] Test cleanup fixes 2 #191122
Closed
[Reporting] Test cleanup fixes 2 #191122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
reporting/test-cleanup-fixes
branch
2 times, most recently
from
f10e625 to
7985a77
Compare
tsullivan
force-pushed
the
reporting/test-cleanup-fixes
branch
from
7985a77 to
18437ba
Compare
|
/ci |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
tsullivan
commented
Aug 27, 2024
| @@ -108,6 +108,8 @@ export const commonJobsRouteHandlerFactory = ( | |||
| counters, | |||
| { isInternal }, | |||
| async (doc) => { | |||
| // FIXME look for potential report job task in task manager and remove that too | |||
There was a problem hiding this comment.
Handle this separately: #191551
|
@eokoneyo hope you don't mind, I will work on finalizing this PR |
…eing finished and/or remove the report job from task manager
tsullivan
force-pushed
the
reporting/test-cleanup-fixes
branch
from
18437ba to
d407145
Compare
3 tasks
|
This needs to be merged into #192417. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #191676
Follows #190099
Reporting Functional tests and API integration tests potentially create degraded Task Manager metrics. These scenarios will unsuccessful task manager task:
This PR seeks to improve Task Manager metrics for reporting jobs by being more careful in cleanup after tests. A good way to do this is to call
await reportingAPI.expectAllJobsToFinishSuccessfully(reportPaths)in theafter()hook before remove the user and test archive data.