Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability Onboarding] Add ARIA labels to option containers on the main screen #190707

Merged

Conversation

mykolaharmash
Copy link
Contributor

@mykolaharmash mykolaharmash commented Aug 19, 2024

@mykolaharmash mykolaharmash requested a review from a team as a code owner August 19, 2024 14:40
@mykolaharmash mykolaharmash requested a review from a team August 19, 2024 14:40
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Aug 19, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mykolaharmash mykolaharmash added the release_note:skip Skip the PR/issue when compiling release notes label Aug 19, 2024
@mykolaharmash mykolaharmash force-pushed the onboarding-screen-container-roles branch from f7daadb to d2c955a Compare August 19, 2024 14:53
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 19, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: d2c955a
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-190707-d2c955ae267d

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 247.4KB 247.4KB +81.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mykolaharmash mykolaharmash merged commit cb14fe6 into elastic:main Aug 20, 2024
23 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 20, 2024
@thomheymann
Copy link
Contributor

There's been a regressions as a result of this PR.

The description and icons inside each card are no longer clickable.

This is because they were moved from the label prop to the children prop.

Users now need to click directly on either the radio button or the label itself to select the card. This is not expected behaviour, the entire card should be clickable and change the selection.

Screenshot 2024-08-25 at 13 12 19

@flash1293
Copy link
Contributor

@thomheymann was the comment above fixed already? If not, could you create an issue to track it please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants