simplified tabify #19061
Merged
simplified tabify #19061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
ppisljar
added
WIP
ppisljar
force-pushed
the
enh/tabifyNewVersion
branch
from
84d0645
to
fe48177
Compare
💔 Build Failed |
ppisljar
force-pushed
the
enh/tabifyNewVersion
branch
from
fe48177
to
741ae8c
Compare
💔 Build Failed |
ppisljar
force-pushed
the
enh/tabifyNewVersion
branch
from
741ae8c
to
a8f4350
Compare
💔 Build Failed |
ppisljar
force-pushed
the
enh/tabifyNewVersion
branch
from
a8f4350
to
75ac775
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
ppisljar
force-pushed
the
enh/tabifyNewVersion
branch
from
518099c
to
f7ce7da
Compare
💔 Build Failed |
ppisljar
force-pushed
the
enh/tabifyNewVersion
branch
from
c76422d
to
1d92a2b
Compare
💔 Build Failed |
ppisljar
force-pushed
the
enh/tabifyNewVersion
branch
from
1d92a2b
to
7767c76
Compare
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
timroes
reviewed
Aug 30, 2018
| @@ -24,23 +24,27 @@ import { tabifyGetColumns } from './_get_columns'; | |||
| * Writer class that collects information about an aggregation response and | |||
| * produces a table, or a series of tables. | |||
| * | |||
| * @param {Vis} vis - the vis object to which the aggregation response correlates | |||
| * @param {AggConfigs} aggs - the agg configs object to which the aggregation response correlates | |||
| * @param {boolean} minimalColumns - setting to false will produce metrics for every bucket | |||
There was a problem hiding this comment.
I think this needs adjustements to the new parameters partialRows and metricsAtAllLevels now.
timroes
reviewed
Aug 30, 2018
| */ | ||
| function TabbedAggResponseWriter(aggs, opts) { | ||
| this.opts = opts || {}; | ||
| function TabbedAggResponseWriter(aggs, { metricsAtAllLevels = false, partialRows = false }) { |
There was a problem hiding this comment.
function TabbedAggResponseWriter(aggs, { metricsAtAllLevels = false, partialRows = false }) {
->
function TabbedAggResponseWriter(aggs, { metricsAtAllLevels = false, partialRows = false } = {}) {
That way it will also work if the user didn't specify a 2nd parameter at all.
timroes
reviewed
Aug 30, 2018
| @@ -41,7 +41,7 @@ describe('Vislib Vis Type', function () { | |||
| describe('initialization', () => { | |||
| it('should set the basic response handler if not set', () => { | |||
There was a problem hiding this comment.
it should set the **vislib** response handler if not set
💔 Build Failed |
|
|
retest |
💚 Build Succeeded |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Aug 30, 2018
ppisljar
added a commit
that referenced
this pull request
Aug 31, 2018
timroes
added
the
release_note:plugin_api_changes
💚 Build Succeeded |
This was referenced Sep 6, 2018
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplifies tabify:
all the response handlers are now based on top of this simple tabify.
new table response handler was added which 'emulates' the old table format and is only used by table visualization. Once table visualization gets ported to react this can be removed.
Closes #20197
Closes #22168
QA: No functionality has changed, however every visualization could potentially break due to this as it changes the data format.
Dev-Docs
Custom no data screen
By default Kibana will take care of showing "No data" to the user if no data was retrieved for a visualization. You can disable that behavior by specifying
useCustomNoDataScreen: truein your vis type registration. This flag replaces the earlierhandleNoDataflag due to its confusing name. ThehandleNoDataflag does not have any effect anymore.