Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename task claimers #190542

Merged
merged 9 commits into from
Aug 21, 2024
Merged

Rename task claimers #190542

merged 9 commits into from
Aug 21, 2024

Conversation

mikecote
Copy link
Contributor

In this PR, I'm renaming the task managers as we prepare to rollout the mget task claiming strategy as the default.

Rename:

  • unsafe_mget -> mget
  • default -> update_by_query

@mikecote mikecote added release_note:skip Skip the PR/issue when compiling release notes Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0 labels Aug 14, 2024
@mikecote mikecote self-assigned this Aug 14, 2024
@mikecote
Copy link
Contributor Author

/ci

@mikecote mikecote mentioned this pull request Aug 14, 2024
Open
48 tasks
@mikecote
Copy link
Contributor Author

/ci

@mikecote
Copy link
Contributor Author

@elasticmachine merge upstream

@mikecote
Copy link
Contributor Author

/ci

@mikecote
Copy link
Contributor Author

/ci

@mikecote
Copy link
Contributor Author

@elasticmachine merge upstream

@mikecote
Copy link
Contributor Author

/ci

@mikecote mikecote marked this pull request as ready for review August 19, 2024 13:52
@mikecote mikecote requested a review from a team as a code owner August 19, 2024 13:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@mikecote
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mikecote

ymao1
ymao1 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote merged commit fdae134 into elastic:main Aug 21, 2024
37 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

Assignees

@mikecote mikecote

Labels
backport:skip This commit does not require backporting Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikecote @elasticmachine @kibana-ci @ymao1 @kibanamachine