Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dark theme playground #190492

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Fix dark theme playground #190492

merged 5 commits into from
Aug 29, 2024

Conversation

yansavitski
Copy link
Contributor

@yansavitski yansavitski commented Aug 14, 2024 •
edited by kibanamachine
Loading

  • Fix header and message on DARK Mode
  • Update python code example
image

@yansavitski yansavitski added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:EnterpriseSearch v8.16.0 labels Aug 14, 2024
@yansavitski yansavitski requested a review from joemcelroy August 14, 2024 10:20
@yansavitski yansavitski requested a review from a team as a code owner August 14, 2024 10:20
@joemcelroy
Copy link
Member

we should backport this to 8.15 aswell.

@yansavitski yansavitski added v8.15.0 and removed backport:skip This commit does not require backporting labels Aug 15, 2024
@yansavitski yansavitski enabled auto-merge (squash) August 15, 2024 15:45
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchPlayground 145.7KB 145.5KB -262.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yansavitski yansavitski merged commit 4c77c7a into elastic:main Aug 29, 2024
23 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.15 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.15:
- [Search] [Playground]Improve follow up question flow (#189848)

Manual backport

To create the backport manually run:

node scripts/backport --pr 190492

Questions ?

Please refer to the Backport tool documentation

@yansavitski yansavitski mentioned this pull request Sep 2, 2024
Merged
@yansavitski
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

yansavitski added a commit to yansavitski/kibana that referenced this pull request Sep 2, 2024
@yansavitski
Fix dark theme playground (elastic#190492)
6af9c90 
- Fix header and message on DARK Mode
- Update python code example
<img width="1404" alt="image"
src="https://github.com/user-attachments/assets/34ef7b19-acf9-4dfd-af31-e742fba6901f">

(cherry picked from commit 4c77c7a)

# Conflicts:
#	x-pack/plugins/search_playground/public/components/message_list/assistant_message.tsx
yansavitski added a commit that referenced this pull request Sep 2, 2024
@yansavitski
[8.15] Fix dark theme playground (#190492) (#191902)
f66ec5b 
# Backport

This will backport the following commits from `main` to `8.15`:
- [Fix dark theme playground
(#190492)](#190492)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yan
Savitski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-08-29T12:47:32Z","message":"Fix
dark theme playground (#190492)\n\n- Fix header and message on DARK
Mode\r\n- Update python code example\r\n<img width=\"1404\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/34ef7b19-acf9-4dfd-af31-e742fba6901f\">","sha":"4c77c7a57c2a4d7c604314afc31a9a5ff3062e9d","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.15.0","v8.16.0"],"number":190492,"url":"https://github.com/elastic/kibana/pull/190492","mergeCommit":{"message":"Fix
dark theme playground (#190492)\n\n- Fix header and message on DARK
Mode\r\n- Update python code example\r\n<img width=\"1404\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/34ef7b19-acf9-4dfd-af31-e742fba6901f\">","sha":"4c77c7a57c2a4d7c604314afc31a9a5ff3062e9d"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190492","number":190492,"mergeCommit":{"message":"Fix
dark theme playground (#190492)\n\n- Fix header and message on DARK
Mode\r\n- Update python code example\r\n<img width=\"1404\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/34ef7b19-acf9-4dfd-af31-e742fba6901f\">","sha":"4c77c7a57c2a4d7c604314afc31a9a5ff3062e9d"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphilipse sphilipse sphilipse approved these changes

@joemcelroy joemcelroy joemcelroy approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.15.0 v8.15.1 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yansavitski @joemcelroy @kibana-ci @kibanamachine @sphilipse