Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency @elastic/elasticsearch to ^8.15.0 (main) #190378

Merged
merged 20 commits into from
Aug 23, 2024
Merged

Update dependency @elastic/elasticsearch to ^8.15.0 (main) #190378

merged 20 commits into from
Aug 23, 2024
+145 −145

Conversation

elastic-renovate-prod[bot]
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
@elastic/elasticsearch (source) dependencies minor ^8.14.0 -> ^8.15.0

Release Notes

elastic/elasticsearch-js (@​elastic/elasticsearch)

v8.15.0

Compare Source

Changelog

v8.14.1

Compare Source

Changelog

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@elastic-renovate-prod elastic-renovate-prod bot added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team labels Aug 12, 2024
@elastic-renovate-prod elastic-renovate-prod bot requested review from a team August 12, 2024 23:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@jloleysens
Copy link
Contributor

/ci

@elastic-renovate-prod
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@afharo
Copy link
Member

afharo commented Aug 19, 2024

/ci

@afharo afharo enabled auto-merge (squash) August 19, 2024 09:18
afharo
afharo approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afharo afharo requested a review from a team as a code owner August 19, 2024 14:24
afharo
afharo reviewed Aug 19, 2024
View reviewed changes
packages/core/saved-objects/core-saved-objects-server/src/mapping_definition.ts
properties?: Record<EsPropertyName, EsMappingProperty>;
};
export type SavedObjectsFieldMapping = EsMappingProperty &
EsMappingPropertyBase & {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new MappingSemanticTextProperty doesn't extend base, so it is missing the optional fields field

packages/kbn-es-query/src/filters/build_filters/phrase_filter.ts
@@ -37,7 +37,7 @@ export type ScriptedPhraseFilter = Filter & {
meta: PhraseFilterMeta;
query: {
script: {
script: estypes.InlineScript;
script: estypes.Script;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed 🤷

@afharo afharo added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Aug 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@afharo
Copy link
Member

afharo commented Aug 19, 2024

/ci

@afharo afharo requested a review from a team as a code owner August 19, 2024 16:38
@afharo
Copy link
Member

afharo commented Aug 19, 2024

/ci

@afharo afharo requested a review from a team as a code owner August 19, 2024 18:57
@afharo afharo requested review from a team as code owners August 22, 2024 15:49
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Aug 22, 2024
@afharo
Copy link
Member

afharo commented Aug 22, 2024

/ci

afharo
afharo reviewed Aug 22, 2024
View reviewed changes
x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts
Comment on lines -829 to -830
body: {
script: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just taking advantage of this PR to remove the deprecated use of body here.

@afharo
Copy link
Member

afharo commented Aug 22, 2024

/ci

@banderror banderror requested review from a team and rylnd August 22, 2024 17:01
peteharverson
peteharverson approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest edits for ML LGTM

@afharo afharo disabled auto-merge August 23, 2024 09:55
@walterra
Copy link
Contributor

@afharo just tested File Upload + Playground to make sure it still works with the update pushed in 7d33213.

marshallmain
marshallmain approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@marshallmain marshallmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Solution changes LGTM

rylnd
rylnd approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection Engine changes LGTM! Nice to have those types defined upstream 👍

@afharo
Copy link
Member

afharo commented Aug 23, 2024

thank you @rylnd! Now that everyone approved, let's give it a final run and merge if CI is green 🤞

@afharo
Copy link
Member

afharo commented Aug 23, 2024

/ci

@afharo afharo enabled auto-merge (squash) August 23, 2024 16:23
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 23, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 4c1222b
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-190378-4c1222b85f67

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 811.0KB 811.0KB +8.0B
transform 634.3KB 634.6KB +248.0B
total +256.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
ml 103 101 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit 68a9244 into main Aug 23, 2024
47 checks passed
@afharo afharo deleted the renovate/main-@elasticelasticsearch branch August 23, 2024 17:48
@afharo
Copy link
Member

afharo commented Aug 26, 2024

We ran a few tests in 8.15 to validate if the breaking changes detected in the inference APIs affected any feature in Kibana. We didn't notice any regression, so we'll hold off any backport at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@marshallmain marshallmain marshallmain approved these changes

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

@adcoelho adcoelho adcoelho approved these changes

@rylnd rylnd rylnd approved these changes

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project 💝community NeededFor:Security release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Operations Team label for Operations Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.