Integrate react control group embeddable into dashboard container #190273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
Heenawter
reviewed
Aug 29, 2024
src/plugins/controls/public/react_controls/control_group/get_control_group_factory.tsx
Outdated
Show resolved
Hide resolved
Heenawter
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Left one other comment, but everything else looks good to me. I think between our test coverage + my additional testing here, we should be in really good shape with this refactor 🤞 So excited to see this in - the code is so much cleaner!! And I'm really looking forward to the final cleanup when we officially get to remove the old controls 👀
src/plugins/controls/public/react_controls/control_group/init_controls_manager.ts
Outdated
Show resolved
Hide resolved
nreese
removed
the
ci:project-deploy-observability
botelastic
bot
added
the
ci:project-deploy-observability
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Sep 3, 2024
…iner (elastic#190273)" This reverts commit c272d97.
2 tasks
|
Seems this PR has introduced a performance regression.
|
thomasneirynck
added a commit
that referenced
this pull request
Sep 4, 2024
…iner (#190273) (#191993) #190273 introduced a performance regression. Reverting to move metrics to baseline again and create some time to identify root cause. Co-authored-by: Thomas Neirynck <[email protected]>
1 task
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Sep 5, 2024
…rd container (elastic#190273) (elastic#191993)" This reverts commit 86a63da.
nreese
added a commit
that referenced
this pull request
Sep 10, 2024
…shboard container - reloaded (#192221) PR replaces legacy embeddable control group implementation with react control group implementation in DashboardContainer. #### background Work originally done in #190273. #190273 was reverted by #191993 because of dashboard performance degradation. It was determined that degradation was because new react embeddable controls fixed a regression where dashboard panels are loading before control filters are created. This regression was introduced by #187509. The work around is that this PR keeps the currently broken behavior in main and loads panels before control filters are ready. The thinking is that the migration would replace like for like and not introduce any performance changes. Then, at a later time, the regression could be resolved. #### reviewing These are the same changes from #190273 minus some work to introduce a current regression in main. A full re-review is not needed. --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Hannah Mudge <[email protected]> Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #191137, #190988, #191155
PR replaces legacy embeddable control group implementation with react control group implementation in DashboardContainer.
Test instructions