Remove Profiling section from renovate.json #190178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@renovate opened elastic#188560 to update some dependencies. The "Profiling" section in the renovate.json is not accurate: * We don't use @types/dagre (nobody does. This must have been in profiling at some point but I have no idea.) * peggy is used in many core, platform, and solution places and should not have profiling as the sole owner. This removes @types/dagre and changes the name of the "Profiling" section to be "Peggy", including only peggy and owned by core and operations.
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
1 task
jbudz
reviewed
Aug 8, 2024
| @@ -320,9 +320,9 @@ | |||
| "enabled": true | |||
| }, | |||
| { | |||
| "groupName": "Profiling", | |||
| "matchDepNames": ["peggy", "@types/dagre"], | |||
| "reviewers": ["team:obs-ux-infra_services-team"], | |||
There was a problem hiding this comment.
core / operations aren't really the right teams, we don't maintain any related parts of the UI. Global UX is likely a closer fit.
There was a problem hiding this comment.
Operations owns the peggy packages in the CODEOWNERS:
https://github.com/elastic/kibana/blob/main/.github/CODEOWNERS#L643-L644
Does Global UX maintain these or any usages of peggy?
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@renovate opened #188560 to update some dependencies.
The "Profiling" section in the renovate.json is not accurate:
This removes @types/dagre and changes the name of the "Profiling" section to be "Peggy", including only peggy and owned by core and operations.