[Cloud Security]Misconfiguration preview & Refactor CSP Plugin to include new package #190105

animehart · 2024-08-08T06:16:19Z

Summary

This PR includes the following

Misconfiguration Preview on Alerts hostname
Refactor some CSP Plugin code to be moved to new csp package

Note:

I will add the other Cypress test that covers the other scenario where indices is not empty on separate PR, as this PR is already big enough & there are still some stuff that will be changed before implementing that Cypress test

353329193-5ad22c4e-81c2-4a8b-89f7-fdbc2a686c2d

UPDATE:
As per discussion shown in the comments below, We decided we will be breaking this PR down into 4 smaller chunks to make it easier for us to review.

animehart · 2024-08-08T21:24:58Z

/ci

…fix'

animehart · 2024-08-08T21:52:54Z

/ci

…m:animehart/kibana into misconfiguration-preview-refactor-package

animehart · 2024-08-08T22:52:24Z

/ci

animehart · 2024-08-09T00:31:10Z

/ci

animehart · 2024-08-09T01:03:51Z

/ci

animehart · 2024-08-09T01:30:20Z

/ci

animehart · 2024-08-09T01:56:25Z

/ci

animehart · 2024-08-09T02:30:30Z

/ci

animehart · 2024-08-09T19:47:32Z

/ci

animehart · 2024-08-09T20:28:32Z

/ci

elasticmachine · 2024-08-14T18:31:18Z

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

animehart · 2024-08-14T23:44:28Z

/ci

opauloh

a few comments, but it looking good overall, please add more documentation and also instruction on how to test the PR locally

opauloh · 2024-08-14T18:34:23Z

x-pack/packages/kbn-cloud-security-posture-common/README.md

@@ -0,0 +1 @@
+FILL THIS IN LATER


I believe that should be filled now, even if it is with a simpler description

WOOPS, completely forgotten about this

opauloh · 2024-08-14T18:35:48Z

x-pack/packages/kbn-cloud-security-posture-common/utils/helpers.ts

+  if (e instanceof Error) return e.message;
+  if (typeof e === 'string') return e;
+
+  return defaultMessage; // TODO: i18n


this todo should be very simple to do now, doesn't it?

opauloh · 2024-08-14T18:38:32Z

x-pack/packages/kbn-cloud-security-posture/README.md

@@ -0,0 +1 @@
+FILL THIS IN LATER


Same with the readme, should be filled now, especially to make it clear why there are two packages.

opauloh · 2024-08-15T21:36:16Z

x-pack/packages/kbn-cloud-security-posture/tsconfig.json

+  "kbn_references": [
+    "@kbn/kibana-react-plugin",
+    "@kbn/core",
+    "@kbn/cloud-security-posture-common",
+    "@kbn/search-types",
+    "@kbn/licensing-plugin",
+    "@kbn/data-views-plugin",
+    "@kbn/unified-search-plugin",
+    "@kbn/ui-actions-plugin",
+    "@kbn/field-formats-plugin",
+    "@kbn/data-view-field-editor-plugin",
+    "@kbn/data-plugin",
+    "@kbn/kibana-utils-plugin",
+    "@kbn/charts-plugin",
+    "@kbn/discover-plugin",
+    "@kbn/fleet-plugin",
+    "@kbn/usage-collection-plugin",
+    "@kbn/share-plugin",
+    "@kbn/es-query",


does it really need all these plugins? some are not used, for example, charts, licensing, unified search, discover

isn't it being used on type CspClientPluginStartDeps ?

opauloh · 2024-08-15T21:47:43Z

...public/flyout/entity_details/shared/components/insight_entity/misconfigurations_overview.tsx

+  const queryHostName = {
+    bool: {
+      must: [],
+      filter: [
+        {
+          bool: {
+            should: [{ term: { 'host.name': { value: `${hostName}` } } }],
+            minimum_should_match: 1,
+          },
+        },
+      ],
+      should: [],
+      must_not: [],
+    },
+  };


this can be simplified by removing the defaults values:

const queryHostName = { bool: { should: [{ term: { 'host.name': { value: `${hostName}` } } }], minimum_should_match: 1, }, };

Also, I would recommend moving this to a function outside of the component or memoizing with useCallback to avoid redefining it on every render.

actually I think the query requires the use of must, should and must_ field

opauloh · 2024-08-15T21:48:49Z

...public/flyout/entity_details/shared/components/insight_entity/misconfigurations_overview.tsx

+        color: euiThemeVars.euiColorSuccess,
+      },
+      {
+        key: 'Failed findings',


if this text is going to be rendered in the user interface we should translate it

opauloh · 2024-08-15T21:50:18Z

...public/flyout/entity_details/shared/components/insight_entity/misconfigurations_overview.tsx

+            />
+          </EuiText>
+        ),
+        // Commented this out until we have the expanded flyout


neat:

Suggested change

// Commented this out until we have the expanded flyout

// Todo: Uncomment once we have the expanded flyout

opauloh · 2024-08-15T21:59:09Z

...public/flyout/entity_details/shared/components/insight_entity/misconfigurations_overview.tsx

+          <EuiFlexItem>
+            <EuiFlexGroup direction="column" gutterSize="none">
+              <EuiFlexItem>
+                <EuiText
+                  css={css`
+                    font-size: ${euiTheme.size.l};
+                    font-weight: ${euiTheme.font.weight.bold};
+                  `}
+                >
+                  <b>{'-'}</b>
+                </EuiText>
+              </EuiFlexItem>
+              <EuiFlexItem>
+                <EuiText
+                  css={css`
+                    font-size: ${euiTheme.size.base};
+                    font-weight: ${euiTheme.font.weight.semiBold};
+                  `}
+                  data-test-subj="noFindingsDataTestSubj"
+                >
+                  <FormattedMessage
+                    id="xpack.securitySolution.flyout.right.insights.misconfigurations.noFindingsDescription"
+                    defaultMessage="No Findings"
+                  />
+                </EuiText>
+              </EuiFlexItem>
+            </EuiFlexGroup>
+          </EuiFlexItem>


It's hard to read ternary conditions that contain a component of several lines, I would suggest breaking it down for improved readability:

<EuiFlexGroup gutterSize="none"> {passedFindings === 0 && failedFindings === 0 ? ( <MisconfigurationsEmptyState /> ) : ( <MisconfigurationsScoreChart /> )} </EuiFlexGroup>

PhilippeOberti · 2024-08-19T13:21:07Z

...ess/cypress/e2e/investigations/alerts/expandable_flyout/host_details_insight_accordion.cy.ts

I think this file is misplaced. It currently lives under the alerts folder, but should probably live under a new host folder? If I'm not mistaken, the test code checks the host flyout, not the alert flyout.

moving this file to a new folder (and probably adding correct codeowners for that new folder) would remove the @elastic/security-threat-hunting-investigations team from the review

Omolola-Akinleye

Nice refactor! I just add a few comments

Omolola-Akinleye · 2024-08-19T16:28:44Z

x-pack/packages/kbn-cloud-security-posture/src/utils/utils.ts

+
+export const isAllIndicesEmpty = (indices: Array<IndexDetails | undefined>) => {
+  const notEmptyIndices = indices.find((indice) => indice?.status !== 'empty');
+  return notEmptyIndices ? false : true;


Here we can use provide simple solution with using the Array.some method. Generally, is best to avoid negated variables which can hard to understand.

return indices.some((index)=> index.status !== 'empty')

Omolola-Akinleye · 2024-08-19T16:46:35Z

x-pack/packages/kbn-cloud-security-posture/src/utils/utils.ts

+  };
+};
+
+export const isAllIndicesEmpty = (indices: Array<IndexDetails | undefined>) => {


If this function is to check if there are any available index with documents or data, then one possible suggestion is to rename the function to *isIndexWithDocsAvailable . A little hard to follow from the naming and using negated notEmptyIndices. I saw later code was added for another negation {!cspAllIndicesEmpty && <InsightEntity hostName={hostName} />}

I only see this utility function once, do you plan on using it again? Could wrap this logic inside a useMemo?

Omolola-Akinleye · 2024-08-19T16:51:28Z

x-pack/packages/kbn-cloud-security-posture/type.ts

+}
+
+export interface CspClientPluginStartDeps {
+  // required


Do we need //required and '//optional' comments? In typescript, ? will help differentiate between required optional properties and required properties.

Omolola-Akinleye · 2024-08-19T16:53:44Z

x-pack/plugins/cloud_security_posture/common/types_old.ts

+export type CspStatusCode =
+  | 'indexed' // latest findings index exists and has results
+  | 'indexing' // index timeout was not surpassed since installation, assumes data is being indexed
+  | 'unprivileged' // user lacks privileges for the latest findings index


🚀 Nice additional context here!

kibana-ci · 2024-08-20T09:21:05Z

💚 Build Succeeded

Buildkite Build
Commit: 9f1cc37

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`cloudSecurityPosture`	702	774	+72
`securitySolution`	5652	5732	+80
total			+152

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/cloud-security-posture`	-	27	+27
`@kbn/cloud-security-posture-common`	-	50	+50
total			+77

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cloudSecurityPosture`	477.4KB	689.0KB	⚠️ +211.7KB
`securitySolution`	20.7MB	21.6MB	⚠️ +881.3KB
total			⚠️ +1.1MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cloudSecurityPosture`	16.7KB	16.4KB	-212.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/cloud-security-posture`	-	27	+27
`@kbn/cloud-security-posture-common`	-	50	+50
total			+77

History

💚 Build #228071 succeeded 6b3eab0
💚 Build #227798 succeeded cbb5b51
💔 Build #227793 failed cbb5b51
💚 Build #227748 succeeded c7113be
💔 Build #227721 failed b8f4efb
💔 Build #227524 failed 23bb270

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

maxcold

@animehart Quite a lot of comments from my side. As the PR is very big, I didn't actually get to reviewing the misconfigurations_preview component itself.
totally understandable that you started to implement the component and only in the process realised how many things should be moved to the common plugins. I see two options:

Continue in this PR but with all the comments it will be huge, hard to review and easy to miss bugs
Now when we know most of the things we need to move, we can move gradually, taking our parts of this PR as separate PRs. First step can be creating our new packages but "empty". This will lay down a foundation. Then you can move the types and schemas you need to the new packages. Then hooks and utils. As a last step can go the actual implementation of the preview component. This will be much cleaner, easier to review and simpler for you I think to apply changes.

I'm personally would vote for option 2, wdyt?

maxcold · 2024-08-20T12:00:30Z

x-pack/packages/kbn-cloud-security-posture-common/README.md

+# @kbn/cloud-security-posture-common
+
+This package provides common code consumed in both the browser, i.e. the
+`packages/cloud-security-posture` package and `plugins/cloud_security_posture` plugin, and on the server, i.e. the


packages/kbn-cloud-security-posture

maxcold · 2024-08-20T12:02:32Z

x-pack/packages/kbn-cloud-security-posture-common/README.md

+
+## Maintainers
+
+Maintained by the Cloud Security Posture Team


nit: Cloud Risk Management team. Though the team name might change, so maybe worth just mentioning the overarching Cloud Security Team

maxcold · 2024-08-20T12:09:07Z

x-pack/packages/kbn-cloud-security-posture-common/constants.ts

+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+export const KSPM_POLICY_TEMPLATE = 'kspm';


I see that these are copied over from the cloud_security_posture plugin. The idea of the common package is that we would use the code from this package everywhere. Ideally we shouldn't have any duplicated code after we are done with the creation of shared packages. If you are concerned with the PR size, we can do it in the follow up PR, but right away, without creating tech debt tickets

maxcold · 2024-08-20T12:29:01Z

x-pack/packages/kbn-cloud-security-posture-common/schema/csp_finding.ts

+
+export type CspBenchmarkRuleMetadata = TypeOf<typeof cspBenchmarkRuleMetadataSchema>;
+
+export const cspBenchmarkRuleMetadataSchema = schema.object({


I see it is duplicated from the v3 rule type. Longer term I think we will need to move all the common schemas and types here, versioned and have it here as a source of truth. Let's think how to get rid of this duplication now, eg. import in the v3 from the common and reexport . But overall we still need this TODO TODO: this needs to be defined in a versioned schema because this schema should be versioned and the all the versions should live in the common package

maxcold · 2024-08-20T12:31:05Z

x-pack/packages/kbn-cloud-security-posture-common/types.ts

+ * 2.0.
+ */
+
+export type CspStatusCode =


let's make sure there are no duplications left in our plugin, we should be using types from the common package

so for this one specifically, there seems to be an issue with Telemetry where it doesn't seem to like it when I'm using this type from the package
I have discussed this issue with @CohenIdo but still can't find the fix for it, thus we decided to have 2 separate copy

maxcold · 2024-08-20T13:41:34Z

x-pack/plugins/security_solution/public/flyout/entity_details/host_right/content.tsx

@@ -44,7 +46,12 @@ export const HostPanelContent = ({
  isPreviewMode,
 }: HostPanelContentProps) => {
  const observedFields = useObservedHostFields(observedHost);
-
+  const getSetupStatus = useCspSetupStatusApi({


do we need this logic in the flyout? I don't think the flyout is smth which stays open longer, so we can rely on calling status API once when it's opened, and not to check it every 10s. In our pages we have this logic for the good onboarding experience, but in my opinion, for the flyout we can make it simpler

maxcold · 2024-08-20T13:45:03Z

x-pack/plugins/security_solution/public/flyout/entity_details/host_right/content.tsx

+  const getSetupStatus = useCspSetupStatusApi({
+    refetchInterval: 10000,
+  });
+  const notEmptyIndices = useMemo(() => {


check out the last PR from @JordanSh , he introduced the field in the status API hasMisconfigurationsFindings for this usecase. The current logic doesn't cover the 3rd party indexes
https://github.com/elastic/kibana/pull/190285/files#diff-7e52c60ac5b5f65b46ea55ac2d44c1f2c6783499b6057e7ea4cefc32eb9f16dbR405

maxcold · 2024-08-20T13:48:08Z

x-pack/plugins/security_solution/public/flyout/entity_details/host_right/content.tsx

@@ -71,6 +78,8 @@ export const HostPanelContent = ({
        observedFields={observedFields}
        queryId={HOST_PANEL_OBSERVED_HOST_QUERY_ID}
      />
+      <EuiHorizontalRule />


we probably don't want to show it either. Plus I'd move the logic of checking our indexes inside the new InsightEntity component. And would return null if there are no data. It later will have more insight blocks, this container component doesn't need to know about the internal logic of InsightEntity

maxcold · 2024-08-20T13:48:28Z

...ns/security_solution/public/flyout/entity_details/shared/components/insight_entity/index.tsx

+import { FormattedMessage } from '@kbn/i18n-react';
+import { MisconfigurationsOverview } from './misconfigurations_overview';
+
+export const InsightEntity = <T,>({ hostName }: { hostName: string }) => {


Naming suggestion: EntityInsights

maxcold · 2024-08-20T13:49:06Z

...public/flyout/entity_details/shared/components/insight_entity/misconfigurations_overview.tsx

+            />
+          </EuiText>
+        ),
+        // TODO: Uncomment when we have the expanded flyout


I would remove it now, and add when we work on the expanded flyout

maxcold · 2024-08-20T14:51:58Z

I also noticed that the PR added 1.1Mb to the lazily loaded async chunks which doesn't look good. Again step by step small PR probably would help identify the culprit better

…clude new package PHASE 1 (#190832) ## Summary The previous [PR ](#190105) was way too big and made it hard to review without missing any bugs or potential bugs, Thus we decided we are going to make series of smaller PR to make things more manageable We will be splitting it into 4 PR Phase 1: Creating empty packages for csp and csp-common Phase 2: Move Types from CSP plugin to the Package + Deleting duplicates in the CSP plugin where possible Phase 3: Move Functions, Utils or Helpers, Hooks to Package Phase 4: Misconfiguration Preview feature (with Cypress test and other required test) This is Phase 1 of the initiative --------- Co-authored-by: kibanamachine <[email protected]>

machadoum · 2024-08-23T08:38:07Z

...curity_solution/public/flyout/entity_details/shared/components/insight_entity/index.test.tsx

+ * 2.0.
+ */
+
+// Add stuff here


oops

Suggested change

// Add stuff here

machadoum · 2024-08-23T08:40:39Z

...c/flyout/entity_details/shared/components/insight_entity/misconfigurations_overview.test.tsx

+ * 2.0.
+ */
+
+// Add stuff here


oops

Suggested change

// Add stuff here

machadoum · 2024-08-23T08:55:53Z

...public/flyout/entity_details/shared/components/insight_entity/misconfigurations_overview.tsx

+      <EuiFlexItem>
+        <EuiFlexGroup direction="column" gutterSize="none">
+          <EuiFlexItem>
+            <EuiText


Setting font size using CSS isn't a good practice. EuiText has a property for that called size.

It also happens in several other places in this file.

machadoum · 2024-08-23T08:58:19Z

...public/flyout/entity_details/shared/components/insight_entity/misconfigurations_overview.tsx

+            <EuiFlexItem />
+            <EuiFlexItem
+              css={css`
+                margin-top: ${euiTheme.size.l};


nit: You could use <EuiSpacer> instead of a custom margin-top.

machadoum · 2024-08-23T08:59:59Z

...public/flyout/entity_details/shared/components/insight_entity/misconfigurations_overview.tsx

+import { ExpandablePanel } from '../../../../shared/components/expandable_panel';
+
+export const MisconfigurationsOverview = ({ hostName }: { hostName: string }) => {
+  const queryHostName = useCallback(() => {


This useCallback doesn't make much sense. You are always calling the function on line 38. So, it created a new object for every render. If you want to memoise the query between render to prevent unnecessary rerender, use useMemo.

Suggested change

const queryHostName = useCallback(() => {

const hostNameQuery = useMemo(() => {

And update line 38 to use hostNameQuery

It also might be a good idea to move the query-building function to another file so we don't mix UI and ES querying logic in the same file.

@machadoum
woops, i forgot to close this PR but basically we will split this PR into smaller PR like this #190933 ,
please leave the review on this other PR :) Thanks !

…clude new package PHASE 2 (#190933) ## Summary The previous #190105 was way too big and made it hard to review without missing any bugs or potential bugs, Thus we decided we are going to make series of smaller PR to make things more manageable We will be splitting it into 4 PR Phase 1: Creating empty packages for csp and csp-common Phase 2: Move Types from CSP plugin to the Package + Deleting duplicates in the CSP plugin where possible Phase 3: Move Functions, Utils or Helpers, Hooks to Package Phase 4: Misconfiguration Preview feature (with Cypress test and other required test) This is **Phase 2** of the Process --------- Co-authored-by: kibanamachine <[email protected]>

…clude new package PHASE 3 (#191317) The previous #190105 was way too big and made it hard to review without missing any bugs or potential bugs, Thus we decided we are going to make series of smaller PR to make things more manageable We will be splitting it into 4 PR Phase 1: Creating empty packages for csp and csp-common Phase 2: Move Types from CSP plugin to the Package + Deleting duplicates in the CSP plugin where possible Phase 3: Move Functions, Utils or Helpers, Hooks to Package Phase 4: Misconfiguration Preview feature (with Cypress test and other required test) This is **Phase 3** of the Process, This also includes moving rule versions type This PR is the continuation of this PR #190933 NOTE: Merge phase 2 first before this --------- Co-authored-by: kibanamachine <[email protected]>

…clude new package PHASE 4 (#191677) The previous #190105 was way too big and made it hard to review without missing any bugs or potential bugs, Thus we decided we are going to make series of smaller PR to make things more manageable We will be splitting it into 4 PR Phase 1: Creating empty packages for csp and csp-common Phase 2: Move Types from CSP plugin to the Package + Deleting duplicates in the CSP plugin where possible Phase 3: Move Functions, Utils or Helpers, Hooks to Package Phase 4: Misconfiguration Preview feature (with Cypress test and other required test) <img width="681" alt="353329193-5ad22c4e-81c2-4a8b-89f7-fdbc2a686c2d" src="https://github.com/user-attachments/assets/b369625a-efc5-4292-a690-2c5dffb5483d"> This is Phase 4 of the Process, --------- Co-authored-by: kibanamachine <[email protected]>

animehart added 10 commits July 23, 2024 21:06

kick off misconfiguration flyout

6517be3

Merge branch 'main' into support-alerts-host-preview

6a609d0

more stuff

457da53

update

7183328

update

bc336b4

Merge branch 'main' into support-alerts-host-preview

5ddf177

update colors

cdd6568

added cypress and clean up

875015e

first push

3187a52

refactor part 1

f86e7d2

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

0a425e4

…fix'

kibanamachine and others added 4 commits August 8, 2024 22:05

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

11ef98c

refactor part 2

e74b284

Merge branch 'misconfiguration-preview-refactor-package' of github.co…

32dfd1e

…m:animehart/kibana into misconfiguration-preview-refactor-package

fix conflict

7ac9384

updated i18n.json

0dc7f84

fix i18n

d3ef3de

updated package.json

846ee3d

more refactor

da69272

update

041dd92

animehart added the Team:Cloud Security Cloud Security team related label Aug 14, 2024

animehart added v8.16.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 14, 2024

more cleanup

cbb5b51

opauloh reviewed Aug 15, 2024

View reviewed changes

addressing pr comments

6b3eab0

animehart requested review from a team and removed request for a team August 19, 2024 09:05

PhilippeOberti reviewed Aug 19, 2024

View reviewed changes

Omolola-Akinleye reviewed Aug 19, 2024

View reviewed changes

animehart requested a review from opauloh August 20, 2024 00:52

pr comments

9f1cc37

maxcold reviewed Aug 20, 2024

View reviewed changes

animehart mentioned this pull request Aug 20, 2024

[Cloud Security] Misconfiguration preview & Refactor CSP Plugin to include new package PHASE 1 #190832

Merged

machadoum reviewed Aug 23, 2024

View reviewed changes

This was referenced Aug 24, 2024

[Cloud Security] Misconfiguration preview & Refactor CSP Plugin to include new package PHASE 2 #190933

Merged

[Cloud Security] Misconfiguration preview & Refactor CSP Plugin to include new package PHASE 3 #191317

Merged

opauloh closed this Aug 27, 2024

animehart mentioned this pull request Aug 28, 2024

[Cloud Security] Misconfiguration preview & Refactor CSP Plugin to include new package PHASE 4 #191677

Merged

	// Commented this out until we have the expanded flyout
	// Todo: Uncomment once we have the expanded flyout


		export type CspBenchmarkRuleMetadata = TypeOf<typeof cspBenchmarkRuleMetadataSchema>;

		export const cspBenchmarkRuleMetadataSchema = schema.object({

	const queryHostName = useCallback(() => {
	const hostNameQuery = useMemo(() => {

[Cloud Security]Misconfiguration preview & Refactor CSP Plugin to include new package #190105

[Cloud Security]Misconfiguration preview & Refactor CSP Plugin to include new package #190105

Conversation

animehart commented Aug 8, 2024 • edited Loading

Summary

animehart commented Aug 8, 2024

animehart commented Aug 8, 2024

animehart commented Aug 8, 2024

animehart commented Aug 9, 2024

animehart commented Aug 9, 2024

animehart commented Aug 9, 2024

animehart commented Aug 9, 2024

animehart commented Aug 9, 2024

animehart commented Aug 9, 2024

animehart commented Aug 9, 2024

elasticmachine commented Aug 14, 2024

animehart commented Aug 14, 2024

opauloh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Omolola-Akinleye left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibana-ci commented Aug 20, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

maxcold left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maxcold commented Aug 20, 2024

machadoum Aug 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

machadoum Aug 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

animehart commented Aug 8, 2024 •

edited

Loading

maxcold left a comment •

edited

Loading

machadoum Aug 23, 2024 •

edited

Loading

machadoum Aug 23, 2024 •

edited

Loading