Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Treat METRICS command as source command in autocomplete #190034

Merged
merged 3 commits into from
Aug 8, 2024
Merged

[ES|QL] Treat METRICS command as source command in autocomplete #190034

merged 3 commits into from
Aug 8, 2024

Conversation

vadimkibana
Copy link
Contributor

Summary

Closes #189945

@vadimkibana vadimkibana requested a review from a team as a code owner August 7, 2024 09:43
@vadimkibana vadimkibana added bug Fixes for quality problems that affect the customer experience review release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:ESQL ES|QL related features in Kibana v8.16.0 labels Aug 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

stratoula
stratoula approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@vadimkibana vadimkibana enabled auto-merge (squash) August 7, 2024 10:05
@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

auto-merge was automatically disabled August 8, 2024 15:49

Head branch was pushed to by a user without write access

@vadimkibana vadimkibana enabled auto-merge (squash) August 8, 2024 15:50
@drewdaemon
Copy link
Contributor

Good... but do we even want to be suggesting this command? I thought it was only available on snapshot builds...

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.3MB 3.3MB +10.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vadimkibana vadimkibana merged commit e40c095 into elastic:main Aug 8, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 8, 2024
@stratoula
Copy link
Contributor

I mention that in slack but I am repeating here.

I want this bug to be solved as it is relevant and we will find it in front of us when the command is being released. Also I was waiting for Quynn's hidden flag to be merged. Now we can hide as a follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes review Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:ESQL ES|QL related features in Kibana v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ES|QL] METRICS command is being suggested wrongly
6 participants
@vadimkibana @elasticmachine @drewdaemon @kibana-ci @stratoula @kibanamachine