Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Remove active patterns from Sourcerer #190020

Merged
merged 4 commits into from
Aug 19, 2024
Merged

[Security Solution] Remove active patterns from Sourcerer #190020

merged 4 commits into from
Aug 19, 2024
+20 −22

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Aug 7, 2024 •
edited
Loading

Summary

Another round of field removal, this time I am replacing the activePatterns field with dataView.title based logic for active pattern retrieval.

This is mostly about upgrade flow for sourcerer going from stack v7 to 8.

@lgestc
Copy link
Contributor Author

lgestc commented Aug 7, 2024

/ci

@lgestc lgestc added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Threat Hunting:Investigations Security Solution Investigations Team labels Aug 7, 2024
@lgestc lgestc marked this pull request as ready for review August 7, 2024 14:08
@lgestc lgestc requested review from a team as code owners August 7, 2024 14:08
@lgestc lgestc requested review from hop-dev and xcrzx August 7, 2024 14:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@lgestc lgestc changed the title [Security Solution] Remove active patterns from Sourcerer WIP [Security Solution] Remove active patterns from Sourcerer Aug 7, 2024
@lgestc lgestc force-pushed the remove_active_patterns branch 3 times, most recently from eff549a to 90f42b0 Compare August 8, 2024 06:28
@lgestc lgestc force-pushed the remove_active_patterns branch from 90f42b0 to 91141b8 Compare August 8, 2024 06:30
@lgestc lgestc changed the title WIP [Security Solution] Remove active patterns from Sourcerer [Security Solution] Remove active patterns from Sourcerer Aug 8, 2024
@xcrzx xcrzx removed request for a team and xcrzx August 8, 2024 08:19
stephmilovic
stephmilovic approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lgestc lgestc enabled auto-merge (squash) August 19, 2024 10:45
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.7MB 20.7MB +160.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lgestc lgestc merged commit d1c4bb3 into elastic:main Aug 19, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christineweng christineweng christineweng approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@hop-dev hop-dev hop-dev approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lgestc @elasticmachine @kibana-ci @hop-dev @stephmilovic @christineweng @kibanamachine