[Cloud Security] add agentless ux creation flow #189932
Conversation
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
Omolola-Akinleye
added
release_note:feature
…eye/kibana into agentless-creation-flow-ux
botelastic
bot
added
the
Team:Fleet
Omolola-Akinleye
added
the
ci:project-deploy-security
There was a problem hiding this comment.
Nice work! I like the separation of the agentless and agent-based components. One curiosity question.
There was a problem hiding this comment.
At first, I was concerned with us having a form for agent-based and another for agentless, but I can see there are enough changes that having 1 component would make it significantly more complex.
👍
There was a problem hiding this comment.
Yes this makes the separation of concerns more simple.
| @@ -378,31 +378,18 @@ export function useOnSubmit({ | |||
|
|
|||
| const hasGoogleCloudShell = data?.item ? getCloudShellUrlFromPackagePolicy(data.item) : false; | |||
|
|
|||
| if (hasFleetAddAgentsPrivileges) { | |||
There was a problem hiding this comment.
Wow! This is great. I'm really curious why we don't need this anymore.
There was a problem hiding this comment.
Thank you! That's a good callout. @opauloh I saw in the git history you add the conditions for showing the template prompts. I removed the pop-up condition logic because I believe we are repeating the same logic below. SUBMITTED is used to set status which indicates package policy has been successfully saved or the agent count exists. wdyt? Am I missing anything? cc: @seanrathier
There was a problem hiding this comment.
I think your updated logic below to check for hasFleetAddAgentsPrivileges has covered this piece of logic @Omolola-Akinleye, nice catch
| @@ -378,31 +378,18 @@ export function useOnSubmit({ | |||
|
|
|||
| const hasGoogleCloudShell = data?.item ? getCloudShellUrlFromPackagePolicy(data.item) : false; | |||
|
|
|||
| if (hasFleetAddAgentsPrivileges) { | |||
There was a problem hiding this comment.
I think your updated logic below to check for hasFleetAddAgentsPrivileges has covered this piece of logic @Omolola-Akinleye, nice catch
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
## Summary This PR add UX updates to agentless creation flow which include the following: * Disabling Agent-based popups when newly created policy is Agentless * Adding Cloud Credentials Instructions * Minor UX adjustments such as adding Readme doc link on AWS credentials form and spacing between Azure Credentials form. <img width="985" alt="image" src="https://github.com/user-attachments/assets/47b8dcaa-b63d-478d-b12e-ab6ba1d075eb"> https://github.com/user-attachments/assets/48d3a49e-043d-48f6-ac0c-8e131d47e976 --------- Co-authored-by: Elastic Machine <[email protected]>
Summary
This PR add UX updates to agentless creation flow which include the following:
Screen.Recording.2024-08-05.at.7.08.16.PM.mov