Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Alert Details] Alerts KPI clean up #189837

Merged
merged 3 commits into from
Aug 6, 2024
Merged

[Security Solution][Alert Details] Alerts KPI clean up #189837

merged 3 commits into from
Aug 6, 2024

Conversation

christineweng
Copy link
Contributor

@christineweng christineweng commented Aug 2, 2024 •
edited
Loading

Summary

Removed unused components (those that were replaced by Len Embeddable) and cleaned up jest test console errors. No UI change from this PR.

image

Checklist

@christineweng christineweng added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team v8.16.0 labels Aug 2, 2024
@christineweng christineweng self-assigned this Aug 2, 2024
@christineweng
Copy link
Contributor Author

/ci

@christineweng christineweng mentioned this pull request Aug 2, 2024
Closed
@christineweng christineweng marked this pull request as ready for review August 2, 2024 20:09
@christineweng christineweng requested a review from a team as a code owner August 2, 2024 20:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.5MB 20.5MB -22.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 540 539 -1

Total ESLint disabled count

id before after diff
securitySolution 624 623 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @christineweng

PhilippeOberti
PhilippeOberti approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1500 lines removed, nice cleanup!

@christineweng christineweng merged commit 56a5426 into elastic:main Aug 6, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

Assignees

@christineweng christineweng

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christineweng @elasticmachine @kibana-ci @PhilippeOberti