-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Extend the /upgrade/_perform
API endpoint's contract migrating to Zod
#189790
Conversation
/upgrade/_perform
API endpoint's contract migrating to Zod
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
targetRules.push(target); | ||
break; | ||
case PickVersionValuesEnum.MERGED: | ||
// TODO: Implement functionality to handle MERGED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is an internal endpoint, and we don't use MERGED
yet, this should be safe. Defaulting to updating to TARGET
anyways, until actual endpoint implementation is finished.
...solution/common/api/detection_engine/prebuilt_rules/model/aggregated_prebuilt_rules_error.ts
Outdated
Show resolved
Hide resolved
...ommon/api/detection_engine/prebuilt_rules/perform_rule_upgrade/perform_rule_upgrade_route.ts
Outdated
Show resolved
Hide resolved
...ommon/api/detection_engine/prebuilt_rules/perform_rule_upgrade/perform_rule_upgrade_route.ts
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @jpdjere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you, @jpdjere, for migrating the legacy schemas to Zod, they look much nicer now!
Partially addresses (contract change only): #166376
Created in favour of: #189187 (closed)
Summary
io-ts
to Zod (search forPerform rule upgrade
)For maintainers