Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows][tests] Improve artifacts mocked data CY #189783

Merged

Conversation

gergoabraham
Copy link
Contributor

@gergoabraham gergoabraham commented Aug 2, 2024

Summary

  • unskip artifacts_mocked_data.cy test
  • make test cases independent
  • fix small test bug: check the correct dataset when updating artifacts

flaky runner has passed, see comments

@gergoabraham gergoabraham added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Aug 2, 2024
@gergoabraham gergoabraham self-assigned this Aug 2, 2024
@gergoabraham
Copy link
Contributor Author

/ci

@gergoabraham
Copy link
Contributor Author

@elasticmachine merge upstream

@gergoabraham
Copy link
Contributor Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6673

[✅] Security Solution Defend Workflows - Cypress: 25/25 tests passed.
[✅] [Serverless] Security Solution Defend Workflows - Cypress: 25/25 tests passed.

see run history

@gergoabraham gergoabraham marked this pull request as ready for review August 2, 2024 14:25
@gergoabraham gergoabraham requested a review from a team as a code owner August 2, 2024 14:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@gergoabraham
Copy link
Contributor Author

@elasticmachine merge upstream

@gergoabraham
Copy link
Contributor Author

@elasticmachine merge upstream

@gergoabraham gergoabraham added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Aug 5, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @gergoabraham

operator: 'included',
type: 'match',
value: '1.2.3.4',
value: 'mr agent',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@gergoabraham gergoabraham merged commit 986e760 into elastic:main Aug 5, 2024
41 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 5, 2024
## Summary

- unskip `artifacts_mocked_data.cy` test
- make test cases independent
- fix small test bug: check the correct dataset when updating artifacts

flaky runner has passed, see comments

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 986e760)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@gergoabraham gergoabraham deleted the improve-artifacts-mocked-data-cy branch August 5, 2024 16:18
kibanamachine added a commit that referenced this pull request Aug 6, 2024
…) (#189907)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[EDR Workflows][tests] Improve artifacts mocked data CY
(#189783)](#189783)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gergő
Ábrahám","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-08-05T16:03:43Z","message":"[EDR
Workflows][tests] Improve artifacts mocked data CY (#189783)\n\n##
Summary\r\n\r\n- unskip `artifacts_mocked_data.cy` test\r\n- make test
cases independent\r\n- fix small test bug: check the correct dataset
when updating artifacts\r\n\r\nflaky runner has passed, see
comments\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"986e76075634764f107686ea734ac63e2476a2eb","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","backport:prev-minor","v8.16.0"],"title":"[EDR
Workflows][tests] Improve artifacts mocked data
CY","number":189783,"url":"https://github.com/elastic/kibana/pull/189783","mergeCommit":{"message":"[EDR
Workflows][tests] Improve artifacts mocked data CY (#189783)\n\n##
Summary\r\n\r\n- unskip `artifacts_mocked_data.cy` test\r\n- make test
cases independent\r\n- fix small test bug: check the correct dataset
when updating artifacts\r\n\r\nflaky runner has passed, see
comments\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"986e76075634764f107686ea734ac63e2476a2eb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189783","number":189783,"mergeCommit":{"message":"[EDR
Workflows][tests] Improve artifacts mocked data CY (#189783)\n\n##
Summary\r\n\r\n- unskip `artifacts_mocked_data.cy` test\r\n- make test
cases independent\r\n- fix small test bug: check the correct dataset
when updating artifacts\r\n\r\nflaky runner has passed, see
comments\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"986e76075634764f107686ea734ac63e2476a2eb"}}]}]
BACKPORT-->

Co-authored-by: Gergő Ábrahám <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
@mistic mistic added v8.15.1 and removed v8.15.0 labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.15.1 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants