-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solutions][Alert Details] Add cypress coverage for kpi charts #189758
Conversation
/ci |
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we don't have a clear direction on this (or at least a written down one), but it seems to me that some of these tests could easily live as Jest tests. The added checks are mostly checking existence of DOM elements, and some attributes and classes...
They ressemble the expandable flyout Cypress tests, which I've been wanting to cleanup/remove for a while now, as they don't provide much value compared to the Jest tests...
Maybe @logeekal or @MadameSheema could chime up here.
I also understand that you're only adding to the existing tests, and going with Jest tests could be more involved and could be done as a separate effort entirely!
Finally, if we decide to keep this change as is (which is perfectly fine with me) we should run the Flaky Test Runner and post the result on the PR description.
I 100% agree with Phillipe all those |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6686[✅] Security Solution Investigations - Cypress: 100/100 tests passed. |
fix
aac96e4
to
3aa96eb
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Added cypress tests for navigation and some cypress clean up.