[Security Solution][Detection Engine] Adds support for suppressing EQL sequence alerts #189725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilding block alerts on first alert creation
|
/ci |
…l suppressed alert
|
/ci |
|
/ci |
|
/ci |
maximpn
reviewed
Nov 28, 2024
There was a problem hiding this comment.
@dhurley14 I looked through part of the changes and tested rule creation.
Is it expected behavior that alert suppression get hidden for EQL sequence queries with feature flag disabled?
The PR
Main
...ns/security_solution/public/detection_engine/rule_management/logic/use_alert_suppression.tsx
Outdated
Show resolved
Hide resolved
|
@approksiu what are your thoughts on the linked question below? Is it okay to hide the UI elements when writing an eql sequence query and the feature flag is not enabled? |
@dhurley14 I would prefer to keep the current behavior with showing user that suppression is not supported by EQL sequences. |
dhurley14
commented
Dec 2, 2024
x-pack/plugins/security_solution/common/experimental_features.ts
Outdated
Show resolved
Hide resolved
|
We had a discussion, and I changed my mind. We will keep the current behavior: hiding the component on the disabled feature flag, and plan to release it with the feature flag enabled by default. cc @maximpn @dhurley14 |
…a into eql-sequence-suppression
maximpn
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
@dhurley14 Thanks for responding on my comments 🙏
I tested the PR and haven't revealed any issues.
…pes support suppression, with eql sequence dependent on feature flag, so that is now the only parameter necessary
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12159631381 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dhurley14
added a commit
that referenced
this pull request
Dec 4, 2024
…ing EQL sequence alerts (#189725) (#202960) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Detection Engine] Adds support for suppressing EQL sequence alerts (#189725)](#189725) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Devin W. Hurley","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-04T12:21:49Z","message":"[Security Solution][Detection Engine] Adds support for suppressing EQL sequence alerts (#189725)\n\n## Summary\r\n\r\nProvide support for suppressing EQL sequence alerts.\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Marshall Main <[email protected]>","sha":"5fa4af9c8b0e0ec675ee2b84b5b60207e3043ffa","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","v9.0.0","Feature:Detection Rules","release_note:feature","Feature:Alert Suppression","Team:Detection Engine","backport:version","v8.18.0"],"number":189725,"url":"https://github.com/elastic/kibana/pull/189725","mergeCommit":{"message":"[Security Solution][Detection Engine] Adds support for suppressing EQL sequence alerts (#189725)\n\n## Summary\r\n\r\nProvide support for suppressing EQL sequence alerts.\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Marshall Main <[email protected]>","sha":"5fa4af9c8b0e0ec675ee2b84b5b60207e3043ffa"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189725","number":189725,"mergeCommit":{"message":"[Security Solution][Detection Engine] Adds support for suppressing EQL sequence alerts (#189725)\n\n## Summary\r\n\r\nProvide support for suppressing EQL sequence alerts.\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Marshall Main <[email protected]>","sha":"5fa4af9c8b0e0ec675ee2b84b5b60207e3043ffa"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Dec 5, 2024
…L sequence alerts (elastic#189725) ## Summary Provide support for suppressing EQL sequence alerts. Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Marshall Main <[email protected]>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
…L sequence alerts (elastic#189725) ## Summary Provide support for suppressing EQL sequence alerts. Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Marshall Main <[email protected]>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
…L sequence alerts (elastic#189725) ## Summary Provide support for suppressing EQL sequence alerts. Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Marshall Main <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
…L sequence alerts (elastic#189725) ## Summary Provide support for suppressing EQL sequence alerts. Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Marshall Main <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…L sequence alerts (elastic#189725) ## Summary Provide support for suppressing EQL sequence alerts. Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Marshall Main <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide support for suppressing EQL sequence alerts.
To test, start up auditbeat and packetbeat locally and run the following:
cd ~/kibana/x-pack/plugins/security_solution/server/lib/detection_engine/scripts && ./post_rule.sh ./rules/queries/sequence_eql_query.jsonThis will create a sample rule to suppress on
agent.namewith a suppression duration of 5 hours and runs every 30 seconds with a 90 second lookback. There is another sequence rule in that dirsequence_eql_query_no_duration.jsonthat will suppress per-execution for testing that functionality.Checklist
Detection Engine Team Checklist:
alertSuppressionForSequenceEqlRuleEnabledhttps://github.com/elastic/security-team/pull/10386