[Task Manager] Add caching to the task partitioning logic #189562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
doakalexi
changed the title
doakalexi
added
Team:ResponseOps
…na into alerting/cache-partitions
|
/ci |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6647[✅] x-pack/test/task_manager_claimer_mget/config.ts: 25/25 tests passed. |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
adcoelho
reviewed
Aug 1, 2024
x-pack/plugins/task_manager/server/lib/task_partitioner.test.ts
Outdated
Show resolved
Hide resolved
adcoelho
approved these changes
Aug 1, 2024
ymao1
approved these changes
Aug 2, 2024
|
|
||
| // update the pod partitions cache after 10 seconds | ||
| if (now - lastUpdated >= CACHE_INTERVAL) { | ||
| const allPodNames = await this.getAllPodNames(); |
There was a problem hiding this comment.
If there's an error retrieving this, should we return the cached partitions?
There was a problem hiding this comment.
Yeah that sounds good, resolved in this commit e39827c
| @@ -67,4 +76,19 @@ describe('getPartitions()', () => { | |||
| 247, 249, 250, 252, 253, 255, | |||
| ]); | |||
| }); | |||
|
|
|||
| test('correctly caches the partitions on 10 second interval ', async () => { | |||
There was a problem hiding this comment.
Can we add a test for handling errors from the discovery service?
There was a problem hiding this comment.
Sure, resolved in this commit e39827c
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #189119
Summary
This PR adds a mechanism to keep the node's calculated partitions in cache for 10 seconds before calling the discovery service again and recalculating them.
Checklist
To verify