Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Revert TM resource based task scheduling issues (#189529) #189554

Merged
merged 1 commit into from
Jul 31, 2024
Merged

[main] Revert TM resource based task scheduling issues (#189529) #189554

merged 1 commit into from
Jul 31, 2024

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Jul 30, 2024

Backport

This will backport the following commits from deploy-fix@1722233551 to main:

Questions ?

Please refer to the Backport tool documentation

@ymao1
Revert TM resource based task scheduling issues (elastic#189529)
483f311 
(cherry picked from commit 3245909)

# Conflicts:
#	x-pack/plugins/task_manager/server/task_type_dictionary.test.ts
@ymao1 ymao1 requested a review from a team as a code owner July 30, 2024 18:11
@ymao1 ymao1 added the backport label Jul 30, 2024
@ymao1 ymao1 requested a review from a team as a code owner July 30, 2024 18:11
@ymao1 ymao1 enabled auto-merge (squash) July 30, 2024 18:11
@ymao1 ymao1 mentioned this pull request Jul 30, 2024
Merged
afharo
afharo approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
taskManager 63 62 -1

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
taskManager 7 5 -2
Unknown metric groups

API count

id before after diff
taskManager 107 105 -2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pmuellr
pmuellr approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1 ymao1 merged commit 7b38be0 into elastic:main Jul 31, 2024
43 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Jul 31, 2024
ymao1 added a commit to ymao1/kibana that referenced this pull request Jul 31, 2024
@ymao1
Revert "[main] Revert TM resource based task scheduling issues (elast…
55981f1 
…ic#189529) (elastic#189554)"

This reverts commit 7b38be0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@pmuellr pmuellr pmuellr approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting backport v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ymao1 @kibana-ci @pmuellr @afharo @kibanamachine