[Custom threshold] Respect query:allowLeadingWildcards in optional query filter #189488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryam-saeidi
added
bug
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
maryam-saeidi
changed the title
maryam-saeidi
changed the title
mgiota
approved these changes
Jul 31, 2024
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
maryam-saeidi
added a commit
to maryam-saeidi/kibana
that referenced
this pull request
Aug 1, 2024
…ery filter (elastic#189488) Partially fixes. elastic#189072 In this PR, we pass the `query:allowLeadingWildcards` for the optional filter to the custom threshold (specifically `getSearchConfigurationBoolQuery` function that generates the related ES Query). |Before|After| |----|---| ||| <img src="https://github.com/user-attachments/assets/70d2de37-2285-450f-88bf-45aa88954019" width=500 /> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 5219a1f)
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
maryam-saeidi
added a commit
that referenced
this pull request
Aug 2, 2024
…onal query filter (#189488) (#189705) # Backport This will backport the following commits from `main` to `8.15`: - [[Custom threshold] Respect query:allowLeadingWildcards in optional query filter (#189488)](#189488) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-31T13:29:04Z","message":"[Custom threshold] Respect query:allowLeadingWildcards in optional query filter (#189488)\n\nPartially fixes. #189072\r\n\r\n## Summary\r\n\r\nIn this PR, we pass the `query:allowLeadingWildcards` for the optional\r\nfilter to the custom threshold (specifically\r\n`getSearchConfigurationBoolQuery` function that generates the related ES\r\nQuery).\r\n\r\n|Before|After|\r\n|----|---|\r\n\r\n|||\r\n\r\n#### Rule\r\n\r\n<img\r\nsrc=\"https://github.com/user-attachments/assets/70d2de37-2285-450f-88bf-45aa88954019\"\r\nwidth=500 />\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5219a1f14d1af812624282e59170503d8a071bd4","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","Feature: Custom threshold","v8.16.0"],"number":189488,"url":"https://github.com/elastic/kibana/pull/189488","mergeCommit":{"message":"[Custom threshold] Respect query:allowLeadingWildcards in optional query filter (#189488)\n\nPartially fixes. #189072\r\n\r\n## Summary\r\n\r\nIn this PR, we pass the `query:allowLeadingWildcards` for the optional\r\nfilter to the custom threshold (specifically\r\n`getSearchConfigurationBoolQuery` function that generates the related ES\r\nQuery).\r\n\r\n|Before|After|\r\n|----|---|\r\n\r\n|||\r\n\r\n#### Rule\r\n\r\n<img\r\nsrc=\"https://github.com/user-attachments/assets/70d2de37-2285-450f-88bf-45aa88954019\"\r\nwidth=500 />\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5219a1f14d1af812624282e59170503d8a071bd4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189488","number":189488,"mergeCommit":{"message":"[Custom threshold] Respect query:allowLeadingWildcards in optional query filter (#189488)\n\nPartially fixes. #189072\r\n\r\n## Summary\r\n\r\nIn this PR, we pass the `query:allowLeadingWildcards` for the optional\r\nfilter to the custom threshold (specifically\r\n`getSearchConfigurationBoolQuery` function that generates the related ES\r\nQuery).\r\n\r\n|Before|After|\r\n|----|---|\r\n\r\n|||\r\n\r\n#### Rule\r\n\r\n<img\r\nsrc=\"https://github.com/user-attachments/assets/70d2de37-2285-450f-88bf-45aa88954019\"\r\nwidth=500 />\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5219a1f14d1af812624282e59170503d8a071bd4"}}]}] BACKPORT-->
kibanamachine
added
v8.15.0
and removed
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes. #189072
Summary
In this PR, we pass the
query:allowLeadingWildcardsfor the optional filter to the custom threshold (specificallygetSearchConfigurationBoolQueryfunction that generates the related ES Query).Rule