[Security Solution][Alert Details] Remove alert type charts feature flag #189437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
added
release_note:skip
|
/ci |
christineweng
force-pushed
the
remove-type-kpi-ff
branch
from
d5f5020 to
da271eb
Compare
|
/ci |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
approved these changes
Jul 31, 2024
Comment on lines
71
to
81
| const sorting: { sort: { field: keyof AlertsByRuleData; direction: SortOrder } } = { | ||
| sort: { | ||
| field: 'value', | ||
| direction: 'desc', | ||
| }, | ||
| }; | ||
|
|
||
| const pagination: {} = { | ||
| pageSize: 25, | ||
| showPerPageOptions: false, | ||
| }; |
There was a problem hiding this comment.
couldn't these 2 be moved to constants outside of the component? It would avoid creating new objects every time to pass to the child component
...ty_solution/public/detections/components/alerts_kpis/alerts_by_rule_panel/alerts_by_rule.tsx
Outdated
Show resolved
Hide resolved
.../security_solution/public/detections/components/alerts_kpis/alerts_by_rule_panel/helpers.tsx
Outdated
Show resolved
Hide resolved
christineweng
force-pushed
the
remove-type-kpi-ff
branch
from
e1435d9 to
fbbba59
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removing an unused feature flag called
alertTypeEnabled. The feature was added in 8.7 (#152872) but was never enabled.This PR removed unused components and renamed directory from
alert_by_type_paneltoalerts_by_rule_panel.Checklist