-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Utilize the DataViewLazy
in ML plugin
#189188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data view service improvements look good, thanks!
Pinging @elastic/ml-ui (:ml) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @darnautov |
Summary
Closes #173996
The benefit of
DataViewLazy
is that it no longer triggers afield_caps
request to Elasticsearch when being initialized. Since fields are not needed for these particular usages in the ML plugin, this change reduces redundant requests to Elasticsearch.This PR also adds the
findLazy
method to the data view service that returnsDataViewLazy
instances instead of theDataView
.Checklist