-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Endpoint] Add authz to file/download apis in support of SentinelOne processes
response action
#189127
[Security Solution][Endpoint] Add authz to file/download apis in support of SentinelOne processes
response action
#189127
Conversation
/ci |
…ents on actions sent to multiples
/ci |
/ci |
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
…uthz-on-file-apis
…uthz-on-file-apis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I also tested it out. Needs that small change in css
argument, else it's good to 🚢 .
const wrappingClassname = useMemo(() => { | ||
return css({ | ||
'.accordion-host-name-button-content': { | ||
'font-size': 'inherit', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I don't remember getting this warning 🤔
When you made the change, did you check the UI to ensure it was picking up the correct font size? (no worries if you did not... I can test it out)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool. thanks.
I'll make this change in the next PR - since I got all approvals here and a green build. Hope that is cool with you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's alright.
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
The following changes were done for Response actions:
running-processes
for SentinelOne) is not allowed to access file information for a different type of action (ex.get-file
)processes
response action is now displayed to the user when the response action row in the table is expandedprocesses
response action is a file download - which will only be visible if user has authz to Processes operationsChecklist