-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] Stop rerendering connector pages unnecessarily #189103
Merged
sphilipse
merged 2 commits into
elastic:main
from
sphilipse:search-stop-connector-rerendering
Jul 25, 2024
Merged
[Search] Stop rerendering connector pages unnecessarily #189103
sphilipse
merged 2 commits into
elastic:main
from
sphilipse:search-stop-connector-rerendering
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
release_note:skip
Skip the PR/issue when compiling release notes
v8.15.0
v8.14.4
labels
Jul 24, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
efegurkan
approved these changes
Jul 25, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 25, 2024
## Summary This stops the connector tabs from incessantly re-rendering. (cherry picked from commit a35d317)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 25, 2024
## Summary This stops the connector tabs from incessantly re-rendering. (cherry picked from commit a35d317)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 25, 2024
…) (#189178) # Backport This will backport the following commits from `main` to `8.14`: - [[Search] Stop rerendering connector pages unnecessarily (#189103)](#189103) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-25T12:29:02Z","message":"[Search] Stop rerendering connector pages unnecessarily (#189103)\n\n## Summary\r\n\r\nThis stops the connector tabs from incessantly re-rendering.","sha":"a35d3178a81f3ff6f9f2b06800ec02a5d7d84ceb","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.15.0","v8.16.0","v8.14.4"],"title":"[Search] Stop rerendering connector pages unnecessarily","number":189103,"url":"https://github.com/elastic/kibana/pull/189103","mergeCommit":{"message":"[Search] Stop rerendering connector pages unnecessarily (#189103)\n\n## Summary\r\n\r\nThis stops the connector tabs from incessantly re-rendering.","sha":"a35d3178a81f3ff6f9f2b06800ec02a5d7d84ceb"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","8.14"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189103","number":189103,"mergeCommit":{"message":"[Search] Stop rerendering connector pages unnecessarily (#189103)\n\n## Summary\r\n\r\nThis stops the connector tabs from incessantly re-rendering.","sha":"a35d3178a81f3ff6f9f2b06800ec02a5d7d84ceb"}},{"branch":"8.14","label":"v8.14.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 25, 2024
…) (#189179) # Backport This will backport the following commits from `main` to `8.15`: - [[Search] Stop rerendering connector pages unnecessarily (#189103)](#189103) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-25T12:29:02Z","message":"[Search] Stop rerendering connector pages unnecessarily (#189103)\n\n## Summary\r\n\r\nThis stops the connector tabs from incessantly re-rendering.","sha":"a35d3178a81f3ff6f9f2b06800ec02a5d7d84ceb","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.15.0","v8.16.0","v8.14.4"],"title":"[Search] Stop rerendering connector pages unnecessarily","number":189103,"url":"https://github.com/elastic/kibana/pull/189103","mergeCommit":{"message":"[Search] Stop rerendering connector pages unnecessarily (#189103)\n\n## Summary\r\n\r\nThis stops the connector tabs from incessantly re-rendering.","sha":"a35d3178a81f3ff6f9f2b06800ec02a5d7d84ceb"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","8.14"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189103","number":189103,"mergeCommit":{"message":"[Search] Stop rerendering connector pages unnecessarily (#189103)\n\n## Summary\r\n\r\nThis stops the connector tabs from incessantly re-rendering.","sha":"a35d3178a81f3ff6f9f2b06800ec02a5d7d84ceb"}},{"branch":"8.14","label":"v8.14.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This stops the connector tabs from incessantly re-rendering.