Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Stop rerendering connector pages unnecessarily #189103

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Jul 24, 2024

Summary

This stops the connector tabs from incessantly re-rendering.

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes v8.15.0 v8.14.4 labels Jul 24, 2024
@sphilipse sphilipse requested a review from a team as a code owner July 24, 2024 16:25
@sphilipse sphilipse enabled auto-merge (squash) July 25, 2024 09:00
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +29.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit a35d317 into elastic:main Jul 25, 2024
20 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 25, 2024
## Summary

This stops the connector tabs from incessantly re-rendering.

(cherry picked from commit a35d317)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 25, 2024
## Summary

This stops the connector tabs from incessantly re-rendering.

(cherry picked from commit a35d317)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 25, 2024
…) (#189178)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Search] Stop rerendering connector pages unnecessarily
(#189103)](#189103)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-25T12:29:02Z","message":"[Search]
Stop rerendering connector pages unnecessarily (#189103)\n\n##
Summary\r\n\r\nThis stops the connector tabs from incessantly
re-rendering.","sha":"a35d3178a81f3ff6f9f2b06800ec02a5d7d84ceb","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.15.0","v8.16.0","v8.14.4"],"title":"[Search]
Stop rerendering connector pages
unnecessarily","number":189103,"url":"https://github.com/elastic/kibana/pull/189103","mergeCommit":{"message":"[Search]
Stop rerendering connector pages unnecessarily (#189103)\n\n##
Summary\r\n\r\nThis stops the connector tabs from incessantly
re-rendering.","sha":"a35d3178a81f3ff6f9f2b06800ec02a5d7d84ceb"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","8.14"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189103","number":189103,"mergeCommit":{"message":"[Search]
Stop rerendering connector pages unnecessarily (#189103)\n\n##
Summary\r\n\r\nThis stops the connector tabs from incessantly
re-rendering.","sha":"a35d3178a81f3ff6f9f2b06800ec02a5d7d84ceb"}},{"branch":"8.14","label":"v8.14.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
kibanamachine added a commit that referenced this pull request Jul 25, 2024
…) (#189179)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Search] Stop rerendering connector pages unnecessarily
(#189103)](#189103)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-25T12:29:02Z","message":"[Search]
Stop rerendering connector pages unnecessarily (#189103)\n\n##
Summary\r\n\r\nThis stops the connector tabs from incessantly
re-rendering.","sha":"a35d3178a81f3ff6f9f2b06800ec02a5d7d84ceb","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.15.0","v8.16.0","v8.14.4"],"title":"[Search]
Stop rerendering connector pages
unnecessarily","number":189103,"url":"https://github.com/elastic/kibana/pull/189103","mergeCommit":{"message":"[Search]
Stop rerendering connector pages unnecessarily (#189103)\n\n##
Summary\r\n\r\nThis stops the connector tabs from incessantly
re-rendering.","sha":"a35d3178a81f3ff6f9f2b06800ec02a5d7d84ceb"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","8.14"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189103","number":189103,"mergeCommit":{"message":"[Search]
Stop rerendering connector pages unnecessarily (#189103)\n\n##
Summary\r\n\r\nThis stops the connector tabs from incessantly
re-rendering.","sha":"a35d3178a81f3ff6f9f2b06800ec02a5d7d84ceb"}},{"branch":"8.14","label":"v8.14.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.14.4 v8.15.0 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants