Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Remove indexFields from security data view type #188932

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Jul 23, 2024

Summary

Remove indexFields from SourcererDataView as we can pull this info from native DataViewSpec.

@lgestc lgestc added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Threat Hunting:Investigations Security Solution Investigations Team labels Jul 23, 2024
@lgestc lgestc requested review from a team as code owners July 23, 2024 12:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@lgestc lgestc force-pushed the remove_index_fields_from_sdv branch 3 times, most recently from a511387 to 57b72d2 Compare August 2, 2024 14:28
@elastic elastic deleted a comment from kibana-ci Aug 2, 2024
@lgestc lgestc force-pushed the remove_index_fields_from_sdv branch from 57b72d2 to 2605175 Compare August 5, 2024 10:21
@lgestc lgestc enabled auto-merge (squash) August 5, 2024 11:43
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
timelines 183 182 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.5MB 20.5MB -39.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
timelines 113.4KB 113.4KB -56.0B
Unknown metric groups

API count

id before after diff
timelines 227 226 -1

History

  • 💔 Build #225598 failed 57b72d28503e053800b07c44540179492f7717c5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lgestc lgestc merged commit 66130a3 into elastic:main Aug 5, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants