[Security Solution][Timeline] Remove BrowserField type #188923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgestc
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
lgestc
force-pushed
the
remove_browser_field_type
branch
from
b689d5e to
915ede1
Compare
| @@ -25,7 +26,7 @@ export const allowSorting = ({ | |||
| browserField, | |||
| fieldName, | |||
| }: { | |||
| browserField: Partial<BrowserField> | undefined; | |||
| browserField: Partial<FieldSpec> | undefined; | |||
michaelolo24
approved these changes
Jul 26, 2024
lgestc
force-pushed
the
remove_browser_field_type
branch
from
842905f to
30a5ad3
Compare
lgestc
force-pushed
the
remove_browser_field_type
branch
from
30a5ad3 to
9131eb0
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
References to deprecated APIs
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
BrowserFieldtype, as it is now replaced with data plugins'FieldSpec.