Add Kibana Dev Container #188887
Merged
Add Kibana Dev Container #188887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ikuni17
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
reviewed
Aug 14, 2024
jbudz
reviewed
Aug 14, 2024
Ikuni17
added a commit
that referenced
this pull request
Aug 15, 2024
## Summary Updates the Optimizer to user FIPS compliant algorithms, otherwise Kibana will crash during startup in development mode. This was originally part of #188887.
jbudz
reviewed
Aug 20, 2024
Ikuni17
added
backport:current-major
jbudz
approved these changes
Aug 20, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @Ikuni17 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Ikuni17
added a commit
to Ikuni17/kibana
that referenced
this pull request
Aug 27, 2024
## Summary - Closes elastic/kibana-operations#101 This PR adds a [Dev Container](https://containers.dev/) to utilize for Kibana local development in an isolated environment. The original intention was to create a local environment for FIPS development because setting up Kibana in FIPS mode is complicated and has the potential to break the user's OS. However, it has been altered to allow for general development if an engineer chooses as well. The idea is for this be a cost efficient replacement for [kibana-remote-dev](https://github.com/elastic/kibana-remote-dev) eventually. ### Testing - In VS Code you should be able to use the `Dev Containers: Clone GitHub Pull Request in Named Container Volume...` command from the Command Palette (F1) to easily test this PR. - See the [docs](https://github.com/elastic/kibana/blob/bd125fc230f06848d62a564dc88d8abfb4f13e88/dev_docs/getting_started/setting_up_a_development_env.mdx#using-the-kibana-dev-container-optional) for additional information on setting up the Dev Container. ### Bazel I tried many different solutions to copy the local Bazel cache into the container to speed up bootstrap, but it either would break Bazel or didn't provide any meaningful boost in performance. I opted to forgo keeping it in this PR due to the complexity and since we're planning to phase out Bazel in the future anyways. (cherry picked from commit d07ffe2) # Conflicts: # .github/CODEOWNERS # .gitignore # renovate.json
Ikuni17
added
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a Dev Container to utilize for Kibana local development in an isolated environment. The original intention was to create a local environment for FIPS development because setting up Kibana in FIPS mode is complicated and has the potential to break the user's OS. However, it has been altered to allow for general development if an engineer chooses as well. The idea is for this be a cost efficient replacement for kibana-remote-dev eventually.
Testing
Dev Containers: Clone GitHub Pull Request in Named Container Volume...command from the Command Palette (F1) to easily test this PR.Bazel
I tried many different solutions to copy the local Bazel cache into the container to speed up bootstrap, but it either would break Bazel or didn't provide any meaningful boost in performance. I opted to forgo keeping it in this PR due to the complexity and since we're planning to phase out Bazel in the future anyways.