Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Explorer] Fix flaky test - Number of installed integrations do not match #188723

Closed
wants to merge 5 commits into from
Closed

[Logs Explorer] Fix flaky test - Number of installed integrations do not match #188723

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c18f3f
Assert with a retry that number of installed packages are equal to th…
awahab07 Jul 19, 2024
005838e
Do no presume all initial integrations are installed in tests.
awahab07 Jul 20, 2024
ae95841
Merge remote-tracking branch 'origin/main' into 188676-logs-explorer-…
awahab07 Jul 20, 2024
b8d6258
Merge remote-tracking branch 'origin/main' into 188676-logs-explorer-…
awahab07 Jul 22, 2024
9987dfc
Merge branch 'main' into 188676-logs-explorer-e2e-number-of-integrati…
elasticmachine Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions x-pack/test/functional/apps/observability_logs_explorer/data_source_selector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
);
cleanupIntegrationsSetup =
await PageObjects.observabilityLogsExplorer.setupInitialIntegrations();

// Ensure that number of installed packages equals the initial packages
await retry.try(async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This change adds a new assertion without modifying the one that makes the test flaky. How does this resolve the test flakiness?

const installedPackagesResponse =
await PageObjects.observabilityLogsExplorer.getInstalledPackages();
expect(installedPackagesResponse.body.items.length).to.eql(initialPackagesTexts.length);
});
});

after(async () => {
Expand Down
7 changes: 7 additions & 0 deletions .../functional/test_suites/observability/observability_logs_explorer/data_source_selector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
);
cleanupIntegrationsSetup =
await PageObjects.observabilityLogsExplorer.setupInitialIntegrations();

// Ensure that number of installed packages equals the initial packages
await retry.try(async () => {
const installedPackagesResponse =
await PageObjects.observabilityLogsExplorer.getInstalledPackages();
expect(installedPackagesResponse.body.items.length).to.eql(initialPackagesTexts.length);
});
});

after(async () => {
Expand Down
Loading