[7.17] [Infra] Limit the number of metrics accepted by Snapshot API (#188181) #188242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#188181) part of [3628](elastic/observability-dev#3628) - private ## Summary After adding 20 items, users can no longer add more metrics and will see the "Add metric" button disabled with a tooltip <img width="1713" alt="image" src="https://github.com/user-attachments/assets/c784b08b-e118-4491-b53d-46bfde898216"> ### How to test - Start a local Kibana instance pointing to an oblt cluster - Navigate to Infrastructure - Try to add more than 20 metrics in the Metrics dropdown. (cherry picked from commit f2d1a8b) # Conflicts: # x-pack/plugins/infra/public/pages/metrics/inventory_view/components/waffle/metric_control/index.tsx # x-pack/plugins/infra/public/pages/metrics/inventory_view/components/waffle/metric_control/mode_switcher.tsx # x-pack/plugins/infra/server/routes/snapshot/index.ts # x-pack/plugins/observability_solution/infra/common/constants.ts # x-pack/plugins/observability_solution/infra/public/pages/metrics/inventory_view/components/waffle/metric_control/custom_metric_form.tsx # x-pack/test/functional/page_objects/infra_home_page.ts
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
jennypavlova
approved these changes
Jul 15, 2024
adelisle
pushed a commit
to Makila-AI/kibana
that referenced
this pull request
Aug 5, 2024
…lastic#188181) (elastic#188242) # Backport This will backport the following commits from `main` to `7.17`: - [[Infra] Limit the number of metrics accepted by Snapshot API (elastic#188181)](elastic#188181) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-12T13:53:53Z","message":"[Infra] Limit the number of metrics accepted by Snapshot API (elastic#188181)\n\npart of [3628](https://github.com/elastic/observability-dev/issues/3628)\r\n- private\r\n\r\n\r\n## Summary\r\n\r\nAfter adding 20 items, users can no longer add more metrics and will see\r\nthe \"Add metric\" button disabled with a tooltip\r\n\r\n<img width=\"1713\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c784b08b-e118-4491-b53d-46bfde898216\">\r\n\r\n\r\n### How to test\r\n\r\n- Start a local Kibana instance pointing to an oblt cluster\r\n- Navigate to Infrastructure\r\n- Try to add more than 20 metrics in the Metrics dropdown.","sha":"f2d1a8b6d24486cedb0dad97e71cd660845f353c","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"number":188181,"url":"https://github.com/elastic/kibana/pull/188181","mergeCommit":{"message":"[Infra] Limit the number of metrics accepted by Snapshot API (elastic#188181)\n\npart of [3628](https://github.com/elastic/observability-dev/issues/3628)\r\n- private\r\n\r\n\r\n## Summary\r\n\r\nAfter adding 20 items, users can no longer add more metrics and will see\r\nthe \"Add metric\" button disabled with a tooltip\r\n\r\n<img width=\"1713\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c784b08b-e118-4491-b53d-46bfde898216\">\r\n\r\n\r\n### How to test\r\n\r\n- Start a local Kibana instance pointing to an oblt cluster\r\n- Navigate to Infrastructure\r\n- Try to add more than 20 metrics in the Metrics dropdown.","sha":"f2d1a8b6d24486cedb0dad97e71cd660845f353c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188181","number":188181,"mergeCommit":{"message":"[Infra] Limit the number of metrics accepted by Snapshot API (elastic#188181)\n\npart of [3628](https://github.com/elastic/observability-dev/issues/3628)\r\n- private\r\n\r\n\r\n## Summary\r\n\r\nAfter adding 20 items, users can no longer add more metrics and will see\r\nthe \"Add metric\" button disabled with a tooltip\r\n\r\n<img width=\"1713\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c784b08b-e118-4491-b53d-46bfde898216\">\r\n\r\n\r\n### How to test\r\n\r\n- Start a local Kibana instance pointing to an oblt cluster\r\n- Navigate to Infrastructure\r\n- Try to add more than 20 metrics in the Metrics dropdown.","sha":"f2d1a8b6d24486cedb0dad97e71cd660845f353c"}},{"url":"https://github.com/elastic/kibana/pull/188231","number":188231,"branch":"8.15","state":"OPEN"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.17:Questions ?
Please refer to the Backport tool documentation