[Security AI Assistant] Changing chat related internal APIs to become public #188139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YulNaumenko
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
History
cc @YulNaumenko |
|
This isn't from your change set here (so just commenting on behavior here), but on a fresh install (with pre-configured connector at least), it looks like we're not automatically selecting a default System Prompt. Changing the conversation or clicking 
|
spong
reviewed
Jul 12, 2024
Comment on lines
+17
to
+21
| export const ELASTIC_AI_ASSISTANT_CONVERSATIONS_URL_BY_ID_MESSAGES = `${ELASTIC_AI_ASSISTANT_INTERNAL_CONVERSATIONS_URL}/{id}/messages`; | ||
|
|
||
| export const ELASTIC_AI_ASSISTANT_CHAT_COMPLETE_URL = `${ELASTIC_AI_ASSISTANT_URL}/chat/complete`; | ||
|
|
||
| export const ELASTIC_AI_ASSISTANT_CONVERSATIONS_URL_BULK_ACTION = `${ELASTIC_AI_ASSISTANT_CONVERSATIONS_URL}/_bulk_action`; | ||
| export const ELASTIC_AI_ASSISTANT_CONVERSATIONS_URL_BULK_ACTION = `${ELASTIC_AI_ASSISTANT_INTERNAL_CONVERSATIONS_URL}/_bulk_action`; |
There was a problem hiding this comment.
Ok, so main conversation routes are now public, but bulk actions and append messages remain internal then?
There was a problem hiding this comment.
We've chat with @peluja1012 about that and decided to keep it this way for now.
spong
approved these changes
Jul 12, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 12, 2024
… public (elastic#188139) ## Summary In this PR Security Gen AI related APIs are changed from internal to public. Conversations APIs: - POST/PUT/GET/DELETE `"/api/security_ai_assistant/current_user/conversations/{id}"` - GET `"/api/security_ai_assistant/current_user/conversations/_find"` Prompts APIs: - POST `"/api/security_ai_assistant/prompts/_bulk_action"` - GET `"/api/security_ai_assistant/current_user/conversations/_find"` Anonymization APIs: - POST `"/api/security_ai_assistant/anonymization_fields/_bulk_action"` - GET `"/api/security_ai_assistant/anonymization_fields/_find"` (cherry picked from commit 1d5cf48)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 12, 2024
… become public (#188139) (#188260) # Backport This will backport the following commits from `main` to `8.15`: - [[Security AI Assistant] Changing chat related internal APIs to become public (#188139)](#188139) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yuliia Naumenko","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-12T19:23:09Z","message":"[Security AI Assistant] Changing chat related internal APIs to become public (#188139)\n\n## Summary\r\n\r\nIn this PR Security Gen AI related APIs are changed from internal to\r\npublic.\r\n\r\nConversations APIs:\r\n- POST/PUT/GET/DELETE\r\n`\"/api/security_ai_assistant/current_user/conversations/{id}\"`\r\n- GET `\"/api/security_ai_assistant/current_user/conversations/_find\"`\r\n\r\nPrompts APIs:\r\n\r\n- POST `\"/api/security_ai_assistant/prompts/_bulk_action\"`\r\n- GET `\"/api/security_ai_assistant/current_user/conversations/_find\"`\r\n\r\nAnonymization APIs:\r\n\r\n- POST `\"/api/security_ai_assistant/anonymization_fields/_bulk_action\"`\r\n- GET `\"/api/security_ai_assistant/anonymization_fields/_find\"`","sha":"1d5cf48a9700ee769f64256c23278fcfd8cecc5d","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.15.0","v8.16.0"],"title":"[Security AI Assistant] Changing chat related internal APIs to become public","number":188139,"url":"https://github.com/elastic/kibana/pull/188139","mergeCommit":{"message":"[Security AI Assistant] Changing chat related internal APIs to become public (#188139)\n\n## Summary\r\n\r\nIn this PR Security Gen AI related APIs are changed from internal to\r\npublic.\r\n\r\nConversations APIs:\r\n- POST/PUT/GET/DELETE\r\n`\"/api/security_ai_assistant/current_user/conversations/{id}\"`\r\n- GET `\"/api/security_ai_assistant/current_user/conversations/_find\"`\r\n\r\nPrompts APIs:\r\n\r\n- POST `\"/api/security_ai_assistant/prompts/_bulk_action\"`\r\n- GET `\"/api/security_ai_assistant/current_user/conversations/_find\"`\r\n\r\nAnonymization APIs:\r\n\r\n- POST `\"/api/security_ai_assistant/anonymization_fields/_bulk_action\"`\r\n- GET `\"/api/security_ai_assistant/anonymization_fields/_find\"`","sha":"1d5cf48a9700ee769f64256c23278fcfd8cecc5d"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188139","number":188139,"mergeCommit":{"message":"[Security AI Assistant] Changing chat related internal APIs to become public (#188139)\n\n## Summary\r\n\r\nIn this PR Security Gen AI related APIs are changed from internal to\r\npublic.\r\n\r\nConversations APIs:\r\n- POST/PUT/GET/DELETE\r\n`\"/api/security_ai_assistant/current_user/conversations/{id}\"`\r\n- GET `\"/api/security_ai_assistant/current_user/conversations/_find\"`\r\n\r\nPrompts APIs:\r\n\r\n- POST `\"/api/security_ai_assistant/prompts/_bulk_action\"`\r\n- GET `\"/api/security_ai_assistant/current_user/conversations/_find\"`\r\n\r\nAnonymization APIs:\r\n\r\n- POST `\"/api/security_ai_assistant/anonymization_fields/_bulk_action\"`\r\n- GET `\"/api/security_ai_assistant/anonymization_fields/_find\"`","sha":"1d5cf48a9700ee769f64256c23278fcfd8cecc5d"}}]}] BACKPORT--> Co-authored-by: Yuliia Naumenko <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR Security Gen AI related APIs are changed from internal to public.
Conversations APIs:
"/api/security_ai_assistant/current_user/conversations/{id}""/api/security_ai_assistant/current_user/conversations/_find"Prompts APIs:
"/api/security_ai_assistant/prompts/_bulk_action""/api/security_ai_assistant/current_user/conversations/_find"Anonymization APIs:
"/api/security_ai_assistant/anonymization_fields/_bulk_action""/api/security_ai_assistant/anonymization_fields/_find"