Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] AIOps: Consolidate code related to retrieving log rate analysis parameters from alert metadata. #188012

Merged
merged 2 commits into from
Jul 15, 2024
Merged

[ML] AIOps: Consolidate code related to retrieving log rate analysis parameters from alert metadata. #188012

merged 2 commits into from
Jul 15, 2024

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Jul 10, 2024 •
edited
Loading

Summary

Part of #178613.

Consolidates code related to retrieving log rate analysis parameters from alert metadata.

Checklist

@walterra walterra added :ml Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.16.0 labels Jul 10, 2024
@walterra walterra self-assigned this Jul 10, 2024
@walterra walterra requested review from a team as code owners July 10, 2024 16:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Jul 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@walterra walterra added the release_note:skip Skip the PR/issue when compiling release notes label Jul 10, 2024
@walterra walterra mentioned this pull request Jul 11, 2024
Closed
peteharverson
peteharverson approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edits to ML file LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 15, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1582 1583 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.5MB 1.5MB +446.0B
observability 367.0KB 367.2KB +254.0B
total +700.0B

History

cc @walterra

benakansara
benakansara approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra merged commit a87d6cc into elastic:main Jul 15, 2024
22 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 15, 2024
@walterra walterra deleted the ml-aiops-log-rate-analysis-window-parameters-for-alerts branch July 15, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benakansara benakansara benakansara approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walterra @elasticmachine @peteharverson @benakansara @kibanamachine