Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.15] [ES|QL] Support counter fields (#186292) #187845

Merged
merged 2 commits into from
Aug 6, 2024
Merged

[8.15] [ES|QL] Support counter fields (#186292) #187845

merged 2 commits into from
Aug 6, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

@jughosta
[ES|QL] Support counter fields (elastic#186292)
b97ae85 
- Closes elastic#186160

## Summary

This PR adds a new util to help with converting ES|QL column into data
view field representation
https://github.com/elastic/kibana/blob/9d63332c74523b00f2b9056352a5b3a86eaf2b75/packages/kbn-data-view-utils/src/utils/convert_to_data_view_field.ts#L13

This allows to handle counter fields in a more predicable way despite of
the different format of ES|QL column data.
elastic#186154 (comment)

<img width="1988" alt="Screenshot 2024-07-03 at 13 48 20"
src="https://github.com/elastic/kibana/assets/1415710/14ce9cd8-8a02-4f3c-8845-c19c30079a75">

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Co-authored-by: Matthias Wilhelm <[email protected]>
(cherry picked from commit 692b656)
@kibanamachine kibanamachine enabled auto-merge (squash) July 9, 2024 10:37
@kibanamachine kibanamachine mentioned this pull request Jul 9, 2024
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 632 633 +1
apm 1888 1889 +1
canvas 1273 1274 +1
cloudSecurityPosture 682 683 +1
dashboard 609 610 +1
data 514 515 +1
dataViewManagement 228 233 +5
dataVisualizer 788 789 +1
discover 940 941 +1
esqlDataGrid 398 399 +1
eventAnnotationListing 618 619 +1
infra 1582 1583 +1
lens 1480 1481 +1
lists 291 292 +1
logsExplorer 600 601 +1
maps 1213 1214 +1
ml 2022 2023 +1
observabilityAIAssistantApp 246 247 +1
presentationUtil 179 184 +5
savedSearch 62 63 +1
securitySolution 5610 5611 +1
slo 855 856 +1
stackAlerts 151 152 +1
unifiedDocViewer 258 259 +1
unifiedHistogram 139 140 +1
unifiedSearch 268 269 +1
total +34

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/data-view-utils 4 5 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 563.0KB 563.2KB +220.0B
cloudSecurityPosture 452.6KB 453.0KB +408.0B
dashboard 529.3KB 529.3KB +44.0B
discover 809.6KB 809.9KB +276.0B
esqlDataGrid 114.4KB 114.8KB +407.0B
lens 1.5MB 1.5MB +44.0B
ml 4.6MB 4.6MB +88.0B
securitySolution 16.6MB 16.6MB +2.2KB
slo 870.1KB 870.5KB +454.0B
unifiedDocViewer 180.4KB 180.8KB +407.0B
total +4.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 420.2KB 420.3KB +44.0B
maps 54.5KB 54.5KB +44.0B
total +88.0B
Unknown metric groups

API count

id before after diff
@kbn/data-view-utils 5 7 +2

cc @jughosta

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 632 633 +1
apm 1888 1889 +1
canvas 1273 1274 +1
cloudSecurityPosture 682 683 +1
dashboard 609 610 +1
data 514 515 +1
dataViewManagement 228 233 +5
dataVisualizer 789 790 +1
discover 940 941 +1
esqlDataGrid 398 399 +1
eventAnnotationListing 618 619 +1
infra 1582 1583 +1
lens 1480 1481 +1
lists 291 292 +1
logsExplorer 600 601 +1
maps 1214 1215 +1
ml 2022 2023 +1
observabilityAIAssistantApp 246 247 +1
presentationUtil 179 184 +5
savedSearch 62 63 +1
securitySolution 5616 5617 +1
slo 855 856 +1
stackAlerts 151 152 +1
unifiedDocViewer 258 259 +1
unifiedHistogram 139 140 +1
unifiedSearch 268 269 +1
total +34

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/data-view-utils 4 5 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 563.2KB 563.4KB +220.0B
cloudSecurityPosture 452.7KB 453.1KB +408.0B
dashboard 529.5KB 529.5KB +44.0B
discover 809.8KB 810.1KB +276.0B
esqlDataGrid 114.4KB 114.8KB +407.0B
lens 1.5MB 1.5MB +44.0B
ml 4.6MB 4.6MB +88.0B
securitySolution 17.2MB 17.2MB +2.2KB
slo 870.1KB 870.5KB +454.0B
unifiedDocViewer 180.4KB 180.8KB +407.0B
total +4.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 420.2KB 420.3KB +44.0B
maps 54.5KB 54.5KB +44.0B
total +88.0B
Unknown metric groups

API count

id before after diff
@kbn/data-view-utils 5 7 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

davismcphee
davismcphee approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kibanamachine kibanamachine merged commit 8f8c521 into elastic:8.15 Aug 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees

@jughosta jughosta

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kibanamachine @elasticmachine @kibana-ci @davismcphee @jughosta