Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Always use a SNAPSHOT version when running elastic-agent docker image #187777

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jul 8, 2024

Resolve #184681

Summary

Test are failing when the latest version is not yet available we should probably use the latest SNAPSHOT instead.

Should fix the following error:

Error response from daemon: manifest for docker.elastic.co/beats/elastic-agent:8.15.0 not found: manifest unknown: manifest unknown

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:Elastic-Agent-Control-Plane backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jul 8, 2024
@nchaulet nchaulet self-assigned this Jul 8, 2024
@nchaulet nchaulet requested a review from a team as a code owner July 8, 2024 16:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @nchaulet

Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nchaulet nchaulet merged commit 834f8fd into elastic:main Jul 9, 2024
31 checks passed
@nchaulet nchaulet deleted the fix-standalone-agent-tests branch July 9, 2024 11:27
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 9, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 9, 2024
…nt docker image (#187777) (#187852)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Fleet] Always use a SNAPSHOT version when running elastic-agent
docker image (#187777)](#187777)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-09T11:27:20Z","message":"[Fleet]
Always use a SNAPSHOT version when running elastic-agent docker image
(#187777)","sha":"834f8fdb375d0c7eef0de974ae5c0f0c0f19b60a","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","Team:Elastic-Agent-Control-Plane","backport:prev-minor","v8.16.0"],"title":"[Fleet]
Always use a SNAPSHOT version when running elastic-agent docker
image","number":187777,"url":"https://github.com/elastic/kibana/pull/187777","mergeCommit":{"message":"[Fleet]
Always use a SNAPSHOT version when running elastic-agent docker image
(#187777)","sha":"834f8fdb375d0c7eef0de974ae5c0f0c0f19b60a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187777","number":187777,"mergeCommit":{"message":"[Fleet]
Always use a SNAPSHOT version when running elastic-agent docker image
(#187777)","sha":"834f8fdb375d0c7eef0de974ae5c0f0c0f19b60a"}}]}]
BACKPORT-->

Co-authored-by: Nicolas Chaulet <[email protected]>
juliaElastic pushed a commit that referenced this pull request Jul 18, 2024
## Summary

Fix for that test was merged here, but the test was not unskipped
#187777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Elastic-Agent-Control-Plane Team:Fleet Team label for Observability Data Collection Fleet team v8.15.0 v8.16.0
Projects
None yet
5 participants