[EEM] Add versioning for entity definitions #187692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miltonhultgren
added
release_note:skip
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
miltonhultgren
commented
Jul 5, 2024
...y_solution/entity_manager/server/lib/entities/ingest_pipeline/generate_history_processors.ts
Outdated
Show resolved
Hide resolved
miltonhultgren
commented
Jul 5, 2024
...ty_solution/entity_manager/server/lib/entities/ingest_pipeline/generate_latest_processors.ts
Outdated
Show resolved
Hide resolved
simianhacker
reviewed
Jul 5, 2024
|
|
||
| const semVerRegex = new RegExp(/^[0-9]{1,}\.[0-9]{1,}\.[0-9]{1,}$/); | ||
| export const semVerSchema = z.string().refine((maybeSemVer) => semVerRegex.test(maybeSemVer), { | ||
| message: 'The string does not match the semver pattern of 1.1.1', |
There was a problem hiding this comment.
Suggested change
| message: 'The string does not match the semver pattern of 1.1.1', | |
| message: 'The string does use Semantic Versioning (Semver) format of {major}.{minor}.{patch} (e.g., 1.0.0), ensure each part contains only digits.', |
simianhacker
approved these changes
Jul 5, 2024
simianhacker
reviewed
Jul 5, 2024
...ervability_solution/entity_manager/server/lib/entities/create_and_install_ingest_pipeline.ts
Show resolved
Hide resolved
simianhacker
reviewed
Jul 5, 2024
...ervability_solution/entity_manager/server/lib/entities/create_and_install_ingest_pipeline.ts
Show resolved
Hide resolved
simianhacker
reviewed
Jul 5, 2024
...vability_solution/entity_manager/server/lib/entities/transform/generate_history_transform.ts
Show resolved
Hide resolved
simianhacker
reviewed
Jul 5, 2024
...rvability_solution/entity_manager/server/lib/entities/transform/generate_latest_transform.ts
Show resolved
Hide resolved
|
@simianhacker I'll take it! |
miltonhultgren
commented
Jul 5, 2024
| @@ -88,7 +88,7 @@ describe('checking migration metadata changes on all registered SO types', () => | |||
| "endpoint:unified-user-artifact-manifest": "71c7fcb52c658b21ea2800a6b6a76972ae1c776e", | |||
| "endpoint:user-artifact-manifest": "1c3533161811a58772e30cdc77bac4631da3ef2b", | |||
| "enterprise_search_telemetry": "9ac912e1417fc8681e0cd383775382117c9e3d3d", | |||
| "entity-definition": "33fe0194bd896f0bfe479d55f6de20f8ba1d7713", | |||
| "entity-definition": "ac192f757eff0fc965b67965a02981361cb2f241", | |||
There was a problem hiding this comment.
The comment in this test file to trigger this review is :chefs-kiss:
|
CI is telling us some metrics about our SO type, I've added those notes to this issue https://github.com/elastic/elastic-entity-model/issues/96 which is about cleaning up the SO type. |
klacabane
approved these changes
Jul 8, 2024
pgayvallet
reviewed
Jul 8, 2024
x-pack/plugins/observability_solution/entity_manager/server/saved_objects/entity_definition.ts
Show resolved
Hide resolved
x-pack/plugins/observability_solution/entity_manager/server/lib/entities/built_in/services.ts
Outdated
Show resolved
Hide resolved
tommyers-elastic
approved these changes
Jul 8, 2024
pgayvallet
approved these changes
Jul 9, 2024
…gren/kibana into eem-add-version-to-components
⏳ Build in-progress
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
versionfield to theEntityDefinitiontype, making it required in the API calls. It must be a SemVer string.The version is added to the ingest pipelines and transforms as part of their metadata.
The version is included in the output documents alongside the schema version.