Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Skip project image build if manifest exists on pull requests #187680

Merged
merged 2 commits into from
Jul 8, 2024
Merged

[ci] Skip project image build if manifest exists on pull requests #187680

merged 2 commits into from
Jul 8, 2024

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Jul 5, 2024

Currently, if a container image already exists for a project the script exits early with a failure. In cases where CI is re-triggered, this can be inconvenient and require an upstream merge to rebuild.

Instead of exiting early, this skips the image build on pull requests.

@jbudz
[ci] Skip project image build if manifest exists on pull requests
c7a5e7c 
Currently, if a container image already exists for a project the script
exits early with a failure.  In cases where CI is re-triggered, this can
be inconvenient and require an upstream merge to rebuild.

Instead of exiting early, this skips the image build on pull requests/
@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project labels Jul 5, 2024
@jbudz
Copy link
Member Author

jbudz commented Jul 5, 2024

buildkite test this

@jbudz jbudz marked this pull request as ready for review July 5, 2024 16:31
@jbudz jbudz requested a review from a team as a code owner July 5, 2024 16:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz
Copy link
Member Author

jbudz commented Jul 8, 2024

buildkite test this

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 8, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / UnifiedFieldList should render correctly

Metrics [docs]

✅ unchanged

History

@jbudz jbudz enabled auto-merge (squash) July 8, 2024 19:25
@jbudz jbudz merged commit cecdf31 into elastic:main Jul 8, 2024
24 of 25 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delanni delanni delanni approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbudz @elasticmachine @delanni @kibanamachine