Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Chart switch redesign #187475
[Lens] Chart switch redesign #187475
Changes from 38 commits
1d6907f
c51b103
6f5b7f6
06c32e6
c7994ed
ee5220a
97fc4bd
8c0b8b3
54ec813
73c6a30
60c884a
311947f
2ff6955
a384e8d
5d0bffb
063cb59
4c01997
f8a4687
c427714
3d2b1ae
1d703c4
9681afa
f379275
fcde6fd
fc8c741
80fc5ac
aa6dfed
adab691
b088966
87e1adb
8cb1347
92eae1f
a863fb5
88740a1
b4d7f0f
903a711
af42238
2ad0c43
a2b187c
d8fed3e
e58c5c3
14e0c1f
5435f50
b89d264
ff8642f
2b8f60d
14b1f7a
529b174
7b2a121
725e266
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of questions, in particular related to the new "stacking" behaviour cc @teresaalvarezsoler @MichaelMarcialis :
stacked
. One layer amongst the config is unstacked? Then stack all the others together and keep the unstacked separate.I think that the combination of "hide when not useful" pattern combined for both per layer stacked control and in the popover makes it a bit harder to discover this new feature. While I agree to not make the UI too complex, in this case probably it can be an exception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dej611 good points
This is a very good point and definitely a reason to always show the stacking options.
I agree with the issues for this. We may even hit some backward compatibility issues.
I also had similar concerns when I was testing it.
@MichaelMarcialis IMO these are strong reasons to always show the stacking options when there is a bar or area chart regardless of whether there is a breakdown dimension. I fully agree with Marco the gains of showing options when they are most relevant to keep the UI cleaner doesn't compensate the lost of functionality for the edge cases mentioned above and the discoverability issues. Any reasons why we shouldn't do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teresaalvarezsoler: This is a pretty dense topic, so I'd be happy to jump on a Zoom if ya'll want to discuss in person.
In short, I was attempting to accommodate for all possible cases in my designs, including the possibility that users might desire to create a visualization comprised two layers where both layers have stacked breakdowns but the layers themselves are not stacked. In order to do that, we would need to distinguish between layer-level breakdown stacking and visualization-level layer stacking (thus the layer and toolbar controls).
If ya'll are comfortable with not accommodating for such edge cases, then I think I'd be OK with what @dej611 is proposing for the sake of further simplification. Thoughts?