Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make EntityDefinition 'type' a plain string instead of an enum #187451

Conversation

tommyers-elastic
Copy link
Contributor

make EntityDefinition 'type' a plain string instead of an enum

@tommyers-elastic tommyers-elastic added the release_note:skip Skip the PR/issue when compiling release notes label Jul 3, 2024
@tommyers-elastic tommyers-elastic requested a review from a team as a code owner July 3, 2024 09:18
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / AllCasesListGeneric Actions Assignees should show the assignees filters on platinum license

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/entities-schema 20 18 -2
Unknown metric groups

API count

id before after diff
@kbn/entities-schema 20 18 -2

@tommyers-elastic tommyers-elastic merged commit 19db776 into elastic:main Jul 3, 2024
22 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jul 3, 2024
@miltonhultgren miltonhultgren added the Feature:EEM Elastic Entity Model label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:EEM Elastic Entity Model release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants