[Embeddables Rebuild] [Controls] Fix data control editor type selector #187390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heenawter
added
Team:Presentation
|
/ci |
Heenawter
force-pushed
the
embeddableRebuild_controls_fix-data-editor_07-02-2024
branch
from
c5fa242 to
dd266fc
Compare
|
/ci |
|
/ci |
|
/ci |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
cc @Heenawter |
ThomThomson
approved these changes
Jul 3, 2024
Heenawter
deleted the
embeddableRebuild_controls_fix-data-editor_07-02-2024
branch
kibanamachine
added
v8.15.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #187382
Summary
This PR separates out the previously memoized
CompatibleControlTypesComponentinto a separate component that accepts props for the fields that it is dependant on rather than relying on the dependencies to theuseMemofunction. This is because, previously, we had an extra dependency in the dependency array (controlType) that was causing the memoized component to render too many times and it was causing a weird bug where the old "disabled" menu item wasn't getting unmounted properly.By switching to a component with explicit props, unnecessary dependencies should hopefully be avoided in the future.
For maintainers