Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obs AI assistant] Replace with double quotes #187327

Merged
merged 8 commits into from
Jul 5, 2024
Merged

[Obs AI assistant] Replace with double quotes #187327

merged 8 commits into from
Jul 5, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jul 2, 2024 •
edited by kibanamachine
Loading

Summary

Follow up of elastic/elasticsearch#108395

Checklist

@stratoula
Copy link
Contributor Author

/ci

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.15.0 labels Jul 2, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review July 2, 2024 09:56
@stratoula stratoula requested a review from a team as a code owner July 2, 2024 09:57
@stratoula stratoula added the Team:Obs AI Assistant Observability AI Assistant label Jul 2, 2024
@stratoula
Copy link
Contributor Author

stratoula commented Jul 2, 2024 •
edited
Loading

@dgieselaar I took the liberty to do this. Wdyt? (there are not many cases that will need the double quotes but is def moving us to a safer place)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jul 3, 2024
@stratoula @sorenlouv
Update x-pack/plugins/observability_solution/observability_ai_assista…
39068df 
…nt_app/server/functions/query/correct_common_esql_mistakes.test.ts

Co-authored-by: Søren Louv-Jansen <[email protected]>
dgieselaar
dgieselaar reviewed Jul 4, 2024
View reviewed changes
...n/observability_ai_assistant_app/server/functions/query/correct_common_esql_mistakes.test.ts
input: `FROM 'logs-2024-07-01','logs-2024-07-02' | LIMIT 10`,
expectedOutput: 'FROM "logs-2024-07-01","logs-2024-07-02"\n| LIMIT 10',
});
expectQuery({ input: `FROM logs-* | LIMIT 10`, expectedOutput: 'FROM logs-*\n| LIMIT 10' });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add one here for backticks as well? i see the LLM do this all the time now 😄

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 4, 2024 •
edited
Loading

⏳ Build in-progress

History

@stratoula stratoula added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 and removed backport:skip This commit does not require backporting labels Jul 5, 2024
@stratoula stratoula merged commit 7b635f3 into elastic:main Jul 5, 2024
25 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 5, 2024
@stratoula
[Obs AI assistant] Replace with double quotes (elastic#187327)
9a591f3 
## Summary

Follow up of elastic/elasticsearch#108395

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Søren Louv-Jansen <[email protected]>
(cherry picked from commit 7b635f3)
@kibanamachine kibanamachine mentioned this pull request Jul 5, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

stratoula added a commit that referenced this pull request Jul 5, 2024
@kibanamachine @stratoula
[8.15] [Obs AI assistant] Replace with double quotes (#187327) (#187655)
e306ae6 
# Backport

This will backport the following commits from `main` to `8.15`:
- [[Obs AI assistant] Replace with double quotes
(#187327)](#187327)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-05T10:54:45Z","message":"[Obs
AI assistant] Replace with double quotes (#187327)\n\n##
Summary\r\n\r\nFollow up of
https://github.com/elastic/elasticsearch/pull/108395\r\n\r\n###
Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Søren Louv-Jansen
<[email protected]>","sha":"7b635f3246d9f827380d4d89441cdfaf8aadd468","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","Team:Obs
AI
Assistant","ci:project-deploy-observability","v8.15.0","v8.16.0"],"title":"[Obs
AI assistant] Replace with double
quotes","number":187327,"url":"https://github.com/elastic/kibana/pull/187327","mergeCommit":{"message":"[Obs
AI assistant] Replace with double quotes (#187327)\n\n##
Summary\r\n\r\nFollow up of
https://github.com/elastic/elasticsearch/pull/108395\r\n\r\n###
Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Søren Louv-Jansen
<[email protected]>","sha":"7b635f3246d9f827380d4d89441cdfaf8aadd468"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187327","number":187327,"mergeCommit":{"message":"[Obs
AI assistant] Replace with double quotes (#187327)\n\n##
Summary\r\n\r\nFollow up of
https://github.com/elastic/elasticsearch/pull/108395\r\n\r\n###
Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Søren Louv-Jansen
<[email protected]>","sha":"7b635f3246d9f827380d4d89441cdfaf8aadd468"}}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.15.0 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stratoula @kibana-ci @elasticmachine @kibanamachine @sorenlouv @dgieselaar