Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove joi leakage to the browser in @kbn/search-connectors #187267

Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented Jul 1, 2024

Summary

When working on #186547, I noticed that some bundle sizes were affected... This PR removes leaking point of joi to the browser 😇

For maintainers

@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jul 1, 2024
@afharo afharo self-assigned this Jul 1, 2024
@afharo
Copy link
Member Author

afharo commented Jul 1, 2024

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2337 2274 -63
serverlessSearch 346 281 -65
total -128

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.7MB 2.5MB -190.1KB
serverlessSearch 513.4KB 320.7KB -192.8KB
total -382.9KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

@afharo afharo marked this pull request as ready for review July 1, 2024 18:08
@afharo afharo requested a review from a team as a code owner July 1, 2024 18:08
@afharo afharo enabled auto-merge (squash) July 1, 2024 19:06
@afharo afharo merged commit 4849a8f into elastic:main Jul 1, 2024
25 checks passed
@afharo afharo deleted the kbn-search-connectors/remove-joi-leakage branch July 1, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants