[Fleet] Allow global data tags to be readonly

[nchaulet]

Summary

Resolve #187045

Implement a disabled state for global data tags.

UI Changes

With a user that has read only access to agent policies

Test

This change is covered by unit tests

Further discusssions

@elastic/fleet, @cmacknz had a really good point on how we can prevent this kind of bugs to appear? this one is a little specific as it is a really custom component, but in general maybe we could benefits of unifying a little how we build our forms and support disabled forms, consider using a form library something like formik? it looks like there is so many ways form are implemented in Kibana

[obltmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[jen-huang]

@elastic/fleet, @cmacknz had a really good point on how we can prevent this kind of bugs to appear? this one is a little specific as it is a really custom component, but in general maybe we could benefits of unifying a little how we build our forms and support disabled forms, consider using a form library something like formik? it looks like there is so many ways form are implemented in Kibana

Forms are complex. IMO it's a losing battle trying to engineer a comprehensive solution against all possible permutations. That said, we do have enough usage examples of "disable entire form" to give to the EUI team for them to brainstorm possible EUI solutions that could work across Kibana.

[jen-huang]

Code LGTM

[kpollich]

had a really good point on how we can prevent this kind of bugs to appear? this one is a little specific as it is a really custom component, but in general maybe we could benefits of unifying a little how we build our forms and support disabled forms, consider using a form library something like formik? it looks like there is so many ways form are implemented in Kibana

The form implementation provided by EUI is opinionated in some ways, but is generally not opinionated with how form state is handled. This is where libraries like Formik or https://react-hook-form.com/ could be considered useful. We'd still need to build meaningful abstractions around whatever library we put in place to do things like disabling forms when certain permissions are not met, so I think we'd still need new patterns in place to prevent things like this in the future.

I agree with the sentiment though that any time we build a CRUD form for a particular resource it should be impossible for the form to be editable without the core permissions required to edit that resource.

[nchaulet]

@elasticmachine merge upstream

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 17ddcc7

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
fleet	1.8MB	1.8MB	+308.0B

History

• 💛 Build #218480 was flaky 7ff6f99

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet