Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove Agent Debug Info #187126

Merged
merged 8 commits into from
Jul 8, 2024

Conversation

Ikuni17
Copy link
Contributor

@Ikuni17 Ikuni17 commented Jun 28, 2024

Summary

  • Removes SSH info to avoid confusion since we cannot SSH into agents on the new infra
  • Removes old agent metrics and logs links because they are in a different cluster and the new links are in an annotation

@Ikuni17 Ikuni17 added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release v8.15.0 labels Jun 28, 2024
@Ikuni17 Ikuni17 self-assigned this Jun 28, 2024
@Ikuni17
Copy link
Contributor Author

Ikuni17 commented Jun 28, 2024

/ci

@Ikuni17
Copy link
Contributor Author

Ikuni17 commented Jul 4, 2024

/ci

@Ikuni17 Ikuni17 marked this pull request as ready for review July 4, 2024 03:35
@Ikuni17 Ikuni17 requested a review from a team as a code owner July 4, 2024 03:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@@ -12,17 +12,10 @@ else
source .buildkite/scripts/common/setup_node.sh
source .buildkite/scripts/common/setup_buildkite_deps.sh

echo '--- Agent Debug/SSH Info'
echo '--- Agent Debug Info'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this all entirely, the metrics are going to a different cluster now. Links are available in the Agent information from gobld annotation.

@Ikuni17 Ikuni17 requested a review from jbudz July 8, 2024 19:45
@Ikuni17 Ikuni17 changed the title Update agent links, SSH info Remove Agent Debug Info Jul 8, 2024
@Ikuni17 Ikuni17 enabled auto-merge (squash) July 8, 2024 19:47
@Ikuni17 Ikuni17 changed the title Remove Agent Debug Info [CI] Remove Agent Debug Info Jul 8, 2024
@Ikuni17 Ikuni17 merged commit dd9d643 into elastic:main Jul 8, 2024
22 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #12 / APM API tests correlations/failed_transactions.spec.ts trial 8.0.0 "before all" hook: runBefore in "8.0.0"

Metrics [docs]

✅ unchanged

History

cc @Ikuni17

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2024
## Summary

- Removes SSH info to avoid confusion since we cannot SSH into agents on
the new infra
- Removes old agent metrics and logs links because they are in a
different cluster and the new links are in an annotation

(cherry picked from commit dd9d643)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 187126

Questions ?

Please refer to the Backport tool documentation

@Ikuni17 Ikuni17 deleted the chore/update-agent-links-ssh-info branch July 8, 2024 22:04
@Ikuni17
Copy link
Contributor Author

Ikuni17 commented Jul 8, 2024

💚 All backports created successfully

Status Branch Result
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Ikuni17 added a commit that referenced this pull request Jul 9, 2024
# Backport

This will backport the following commits from `main` to `8.15`:
- [Remove Agent Debug Info
(#187126)](#187126)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Brad
White","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-08T21:10:14Z","message":"Remove
Agent Debug Info (#187126)\n\n## Summary\r\n\r\n- Removes SSH info to
avoid confusion since we cannot SSH into agents on\r\nthe new infra\r\n-
Removes old agent metrics and logs links because they are in
a\r\ndifferent cluster and the new links are in an
annotation","sha":"dd9d6434cae8b7beb3b730cd42898b8f63dbee91","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.15.0","v8.16.0"],"title":"[CI]
Remove Agent Debug
Info","number":187126,"url":"https://github.com/elastic/kibana/pull/187126","mergeCommit":{"message":"Remove
Agent Debug Info (#187126)\n\n## Summary\r\n\r\n- Removes SSH info to
avoid confusion since we cannot SSH into agents on\r\nthe new infra\r\n-
Removes old agent metrics and logs links because they are in
a\r\ndifferent cluster and the new links are in an
annotation","sha":"dd9d6434cae8b7beb3b730cd42898b8f63dbee91"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187126","number":187126,"mergeCommit":{"message":"Remove
Agent Debug Info (#187126)\n\n## Summary\r\n\r\n- Removes SSH info to
avoid confusion since we cannot SSH into agents on\r\nthe new infra\r\n-
Removes old agent metrics and logs links because they are in
a\r\ndifferent cluster and the new links are in an
annotation","sha":"dd9d6434cae8b7beb3b730cd42898b8f63dbee91"}}]}]
BACKPORT-->

---------

Co-authored-by: Brad White <[email protected]>
Co-authored-by: Brad White <[email protected]>
Ikuni17 added a commit that referenced this pull request Jul 9, 2024
# Backport

This will backport the following commits from `main` to `7.17`:
- [Remove Agent Debug Info
(#187126)](#187126)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Brad
White","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-08T21:10:14Z","message":"Remove
Agent Debug Info (#187126)\n\n## Summary\r\n\r\n- Removes SSH info to
avoid confusion since we cannot SSH into agents on\r\nthe new infra\r\n-
Removes old agent metrics and logs links because they are in
a\r\ndifferent cluster and the new links are in an
annotation","sha":"dd9d6434cae8b7beb3b730cd42898b8f63dbee91","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.15.0","v8.16.0"],"number":187126,"url":"https://github.com/elastic/kibana/pull/187126","mergeCommit":{"message":"Remove
Agent Debug Info (#187126)\n\n## Summary\r\n\r\n- Removes SSH info to
avoid confusion since we cannot SSH into agents on\r\nthe new infra\r\n-
Removes old agent metrics and logs links because they are in
a\r\ndifferent cluster and the new links are in an
annotation","sha":"dd9d6434cae8b7beb3b730cd42898b8f63dbee91"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/187802","number":187802,"state":"OPEN"},{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187126","number":187126,"mergeCommit":{"message":"Remove
Agent Debug Info (#187126)\n\n## Summary\r\n\r\n- Removes SSH info to
avoid confusion since we cannot SSH into agents on\r\nthe new infra\r\n-
Removes old agent metrics and logs links because they are in
a\r\ndifferent cluster and the new links are in an
annotation","sha":"dd9d6434cae8b7beb3b730cd42898b8f63dbee91"}}]}]
BACKPORT-->
adelisle pushed a commit to Makila-AI/kibana that referenced this pull request Aug 5, 2024
# Backport

This will backport the following commits from `main` to `7.17`:
- [Remove Agent Debug Info
(elastic#187126)](elastic#187126)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Brad
White","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-08T21:10:14Z","message":"Remove
Agent Debug Info (elastic#187126)\n\n## Summary\r\n\r\n- Removes SSH info to
avoid confusion since we cannot SSH into agents on\r\nthe new infra\r\n-
Removes old agent metrics and logs links because they are in
a\r\ndifferent cluster and the new links are in an
annotation","sha":"dd9d6434cae8b7beb3b730cd42898b8f63dbee91","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.15.0","v8.16.0"],"number":187126,"url":"https://github.com/elastic/kibana/pull/187126","mergeCommit":{"message":"Remove
Agent Debug Info (elastic#187126)\n\n## Summary\r\n\r\n- Removes SSH info to
avoid confusion since we cannot SSH into agents on\r\nthe new infra\r\n-
Removes old agent metrics and logs links because they are in
a\r\ndifferent cluster and the new links are in an
annotation","sha":"dd9d6434cae8b7beb3b730cd42898b8f63dbee91"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/187802","number":187802,"state":"OPEN"},{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187126","number":187126,"mergeCommit":{"message":"Remove
Agent Debug Info (elastic#187126)\n\n## Summary\r\n\r\n- Removes SSH info to
avoid confusion since we cannot SSH into agents on\r\nthe new infra\r\n-
Removes old agent metrics and logs links because they are in
a\r\ndifferent cluster and the new links are in an
annotation","sha":"dd9d6434cae8b7beb3b730cd42898b8f63dbee91"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.23 v8.15.0 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants