Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSQuery Plugin] Migrate usage og authc.getCurrentUser to coreContext.security #187014

Merged

Conversation

tsullivan
Copy link
Member

Part of #186574

Summary

This PR migrates the OSQuery Plugin's route handlers that consume authc.getCurrentUser to use coreContext.security

Background: This PR serves as an example of a plugin migrating away from depending on the Security plugin, which is a high priority effort for the last release before 9.0.

Checklist

Delete any items that are not applicable to this PR.

@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Jun 26, 2024
@tsullivan tsullivan force-pushed the security-in-core/osquery-server-plugin-server branch from e4c9954 to 3016d7c Compare June 26, 2024 20:20
@tsullivan tsullivan force-pushed the security-in-core/osquery-server-plugin-server branch from 3016d7c to 13634bb Compare June 26, 2024 20:22
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
osquery 40 28 -12

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan marked this pull request as ready for review June 27, 2024 01:07
@tsullivan tsullivan requested a review from a team as a code owner June 27, 2024 01:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

Copy link
Contributor

@szwarckonrad szwarckonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no regression spotted locally.

@tsullivan tsullivan merged commit 7cf7365 into elastic:main Jun 28, 2024
20 checks passed
@tsullivan tsullivan deleted the security-in-core/osquery-server-plugin-server branch June 28, 2024 16:26
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants