Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[On-week] Add persisting page size and sorting for Management tables #186997
[On-week] Add persisting page size and sorting for Management tables #186997
Changes from 23 commits
c03a113
c726758
1d1c7fe
69dc047
0dea176
5737a57
05eb300
79ee0b6
68442c9
8e155d6
573b4c9
b0408ef
e8838d1
0cbfb37
cfbcb3d
f4688fd
219031f
e7350b1
0cb54bb
d6c8a52
62d8903
228813c
ada6dd7
096abab
a2aa291
4a22c21
7754207
2aeb917
6948a64
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not easy to parse the double ternary, could we make it more explicit like the below suggestion? Also I would keep the "next" prefix everywhere instead of "new" and "next"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I updated it as suggested, with some modifications due to some recent changes.
On a side note, I just want to note that with the current logic, if the consumer provides an initial sort, when the user removes a sort (the change criteria would contain just the
direction
property, withundefined
field), then we storeundefined
sort in local storage, so next time when the user visits this page, the initial sort will be restored (rather than no sort to be preserved). Just wanted to make sure this is the desired behaviour.