-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security in Core] Exposes apiKeys
from core.security.authc
#186910
Merged
SiddharthMantri
merged 50 commits into
elastic:main
from
SiddharthMantri:security-in-core-api-keys
Jul 9, 2024
Merged
Changes from 47 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
083b1b4
[Security-in-Core]initial work for exposing api keys service in core
SiddharthMantri 25f0509
move public security types to core-security-common
SiddharthMantri 3c0f0c8
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine eb130eb
remove unused types
SiddharthMantri 99ba029
update jest test for api keys
SiddharthMantri 73dc2f0
remove cyclical ts deps, update tsdocs partial
SiddharthMantri 0b13f8d
update security plugin unit test
SiddharthMantri d021ddd
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 1987f8c
fix cyclical dependency on kibana/core
SiddharthMantri 1042962
fix formatting
SiddharthMantri 7892ff2
update delegate api test
SiddharthMantri 471f939
simplify api key type exports
SiddharthMantri 5ac332d
update comments for public ts docs
SiddharthMantri 0dfc26e
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 10a38b6
fix types
SiddharthMantri b83a4c4
Merge branch 'main' into security-in-core-api-keys
kibanamachine fc8af4d
remove unneeded comma
SiddharthMantri f8d8fae
remove unneeded comma
SiddharthMantri 114bfc1
consolidate exported types
SiddharthMantri 219d8f6
fix eslint type issue
SiddharthMantri 381316a
properly await apiKeysEnabled
SiddharthMantri fa37f7d
move changes to core-security-server, expose update in public schema
SiddharthMantri 2b6438e
update imports
SiddharthMantri a8c7795
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 9a21a9a
update mocks
SiddharthMantri 11844e5
fix types
SiddharthMantri 43c8a07
revert formatting changes for tsconfig
SiddharthMantri 850a22a
update mocks for update fn
SiddharthMantri 1932f53
remove unused kbn reference
SiddharthMantri ec18b5b
remove empty comment
SiddharthMantri 7aa2dd3
fix import name
SiddharthMantri 5c12825
update mocks
SiddharthMantri d04f88b
update default implementation to be stub
SiddharthMantri fb9a78f
create explicit decoupled public types, move schema back to plugin
SiddharthMantri 54952ea
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 50c100f
remove typeguards
SiddharthMantri 6b1235e
fix types, update context to expose only contract we need
SiddharthMantri 087db06
add reject when api disabled
SiddharthMantri 06d897d
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine b079606
Update api_keys_context.ts
SiddharthMantri 51b5177
Update api_keys.ts
SiddharthMantri 7b2c26f
revert changes to api keys class constructor
SiddharthMantri caddc90
update type guard to use correct key
SiddharthMantri 2f1915e
Merge branch 'main' into security-in-core-api-keys
SiddharthMantri 7435d87
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 8fb77d3
Merge branch 'main' into security-in-core-api-keys
kibanamachine df6e945
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 1faeaa4
use arrow functions instead of bind
SiddharthMantri 6c85ea3
Merge branch 'main' into security-in-core-api-keys
SiddharthMantri b65a666
Merge branch 'main' into security-in-core-api-keys
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 5 additions & 6 deletions
11
.../authentication/api_keys/api_keys.mock.ts → ...ecurity-server-mocks/src/api_keys.mock.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we can use arrow function instead of bind, like
getCurrentUser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Addressed in 1faeaa4