Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Enable alert preview in document details flyout #186857

Merged
merged 9 commits into from
Jul 2, 2024
Merged

[Security Solution] Enable alert preview in document details flyout #186857

merged 9 commits into from
Jul 2, 2024

Conversation

christineweng
Copy link
Contributor

@christineweng christineweng commented Jun 24, 2024 •
edited
Loading

Summary

This PR enables alert preview in the document flyout.

How to test:

  • Enable feature flag entityAlertPreviewEnabled
  • Generate some alerts and open alert flyout
  • Go to correlations details (expanded section)
  • Click on any hyperlinked rule to open an alert preview
Screen.Recording.2024-06-25.at.8.49.13.PM.mov

Checklist

@christineweng christineweng added backport:skip This commit does not require backporting Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team 8.15 candidate v8.15.0 labels Jun 24, 2024
@christineweng christineweng self-assigned this Jun 24, 2024
@christineweng christineweng force-pushed the alert-preview branch 3 times, most recently from efa0613 to e08302d Compare June 26, 2024 01:56
@christineweng christineweng added the release_note:skip Skip the PR/issue when compiling release notes label Jun 26, 2024
@christineweng christineweng marked this pull request as ready for review June 26, 2024 01:57
@christineweng christineweng requested review from a team as code owners June 26, 2024 01:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

PhilippeOberti
PhilippeOberti reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good overall and desk testing went perfect!

I left a few comments, mainly waiting on some UI direction to make the decision

packages/kbn-expandable-flyout/src/components/preview_section.tsx Outdated Show resolved Hide resolved
x-pack/plugins/security_solution/public/flyout/document_details/preview/footer.tsx Show resolved Hide resolved
x-pack/plugins/security_solution/public/flyout/document_details/preview/footer.tsx Show resolved Hide resolved
.../security_solution/public/flyout/document_details/right/components/correlations_overview.tsx Show resolved Hide resolved
...gins/security_solution/public/flyout/document_details/right/components/entities_overview.tsx Show resolved Hide resolved
...ns/security_solution/public/flyout/document_details/right/components/prevalence_overview.tsx Show resolved Hide resolved
...ugins/security_solution/public/flyout/document_details/right/components/response_section.tsx Outdated Show resolved Hide resolved
...ty_solution/public/flyout/document_details/right/components/threat_intelligence_overview.tsx Show resolved Hide resolved
x-pack/plugins/security_solution/public/flyout/document_details/shared/context.tsx Show resolved Hide resolved
x-pack/plugins/security_solution/public/flyout/shared/components/expandable_panel.tsx Outdated Show resolved Hide resolved
@christineweng christineweng mentioned this pull request Jun 26, 2024
Closed
@christineweng
Copy link
Contributor Author

/ci

PhilippeOberti
PhilippeOberti reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very close, I left a few minor comments

packages/kbn-expandable-flyout/src/components/preview_section.tsx Show resolved Hide resolved
packages/kbn-expandable-flyout/src/components/preview_section.tsx Outdated Show resolved Hide resolved
packages/kbn-expandable-flyout/src/components/preview_section.tsx Show resolved Hide resolved
...olution/public/flyout/document_details/left/components/correlations_details_alerts_table.tsx Outdated Show resolved Hide resolved
...olution/public/flyout/document_details/left/components/correlations_details_alerts_table.tsx Show resolved Hide resolved
x-pack/plugins/security_solution/public/flyout/document_details/preview/footer.tsx Outdated Show resolved Hide resolved
PhilippeOberti
PhilippeOberti approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making all the changes and explaining for the others. This looks awesome!

@christineweng christineweng enabled auto-merge (squash) July 1, 2024 21:08
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5588 5591 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.6MB 15.8MB ⚠️ +241.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @christineweng

@christineweng christineweng merged commit 7c6186a into elastic:main Jul 2, 2024
40 checks passed
@christineweng christineweng mentioned this pull request Jul 2, 2024
Closed
5 tasks
@christineweng christineweng mentioned this pull request Jul 11, 2024
Merged
1 task
christineweng added a commit that referenced this pull request Jul 17, 2024
@christineweng
[Security Solution] Add cypress for expandable flyout previews (#188117)
ff93b41 
## Summary

This PR adds cypress test for the new preview panels that were recently
added (#186857)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 17, 2024
@christineweng
[Security Solution] Add cypress for expandable flyout previews (elast…
d5551ad 
…ic#188117)

## Summary

This PR adds cypress test for the new preview panels that were recently
added (elastic#186857)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit ff93b41)
kibanamachine referenced this pull request Jul 17, 2024
@kibanamachine @christineweng
[8.15] [Security Solution] Add cypress for expandable flyout previews (…
759d70c 
…#188117) (#188570)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Security Solution] Add cypress for expandable flyout previews
(#188117)](#188117)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-17T17:27:37Z","message":"[Security
Solution] Add cypress for expandable flyout previews (#188117)\n\n##
Summary\r\n\r\nThis PR adds cypress test for the new preview panels that
were recently\r\nadded
(https://github.com/elastic/kibana/pull/186857)\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"ff93b415a5e3738be0d64c3e03419d51e8afe621","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team:Threat
Hunting:Investigations","v8.15.0","v8.16.0"],"title":"[Security
Solution] Add cypress for expandable flyout
previews","number":188117,"url":"https://github.com/elastic/kibana/pull/188117","mergeCommit":{"message":"[Security
Solution] Add cypress for expandable flyout previews (#188117)\n\n##
Summary\r\n\r\nThis PR adds cypress test for the new preview panels that
were recently\r\nadded
(https://github.com/elastic/kibana/pull/186857)\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"ff93b415a5e3738be0d64c3e03419d51e8afe621"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188117","number":188117,"mergeCommit":{"message":"[Security
Solution] Add cypress for expandable flyout previews (#188117)\n\n##
Summary\r\n\r\nThis PR adds cypress test for the new preview panels that
were recently\r\nadded
(https://github.com/elastic/kibana/pull/186857)\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"ff93b415a5e3738be0d64c3e03419d51e8afe621"}}]}]
BACKPORT-->

Co-authored-by: christineweng <[email protected]>
This was referenced Aug 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastasha-solomon nastasha-solomon nastasha-solomon left review comments

@kqualters-elastic kqualters-elastic kqualters-elastic left review comments

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

Assignees

@christineweng christineweng

Labels
8.15 candidate backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@christineweng @elasticmachine @kibana-ci @PhilippeOberti @kqualters-elastic @nastasha-solomon