[Obs AI Assistant] Keep connection open, limit no of field names to analyze #186811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
dgieselaar
added
release_note:skip
sorenlouv
reviewed
Jun 24, 2024
Comment on lines
+47
to
+48
| const flushIntervalId = isCloud ? setInterval(flushBufferIfNeeded, 250) : undefined; | ||
| const keepAliveIntervalId = setInterval(keepAlive, 30_000); |
There was a problem hiding this comment.
Shouldn't this be handled at the proxy layer?
There was a problem hiding this comment.
keepAlive not necessarily, flush, hell yes. There's been an open issue for the team that handles the Cloud Proxy to do this.
sorenlouv
approved these changes
Jun 24, 2024
…t-keep-connection-alive
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @dgieselaar |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Jun 28, 2024
…186811) Keeps the connection open even when there is no data, to prevent long-running operations from timing out. Additionally, puts an upper limit of field names to be analyzed. (cherry picked from commit 4aeb790) # Conflicts: # x-pack/plugins/observability_solution/observability_ai_assistant/server/functions/get_dataset_info/get_relevant_field_names.ts # x-pack/plugins/observability_solution/observability_ai_assistant/server/functions/get_dataset_info/index.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
dgieselaar
added a commit
that referenced
this pull request
Jul 17, 2024
…186811) (#187131) # Backport This will backport the following commits from `main` to `8.14`: - [[Obs AI Assistant] Keep connection open, limit no of fields (#186811)](#186811) <!--- Backport version: 7.3.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT {commits} BACKPORT-->
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps the connection open even when there is no data, to prevent long-running operations from timing out. Additionally, puts an upper limit of field names to be analyzed.