-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(apm): flatten globalLabels
object
#186579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
apm:instrumentation
labels
Jun 20, 2024
/ci |
Pinging @elastic/kibana-core (Team:Core) |
vigneshshanmugam
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
botelastic
bot
added
the
ci:project-deploy-observability
Create an Observability project
label
Jun 20, 2024
pgayvallet
approved these changes
Jun 21, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @afharo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apm:instrumentation
backport:skip
This commit does not require backporting
ci:project-deploy-observability
Create an Observability project
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to elastic/apm-agent-nodejs#4096 (comment).
I noticed that the APM agents expect
globalLabels
to be key/value pairs. For this reason, when a label such asmyObject.keyA: A
ormyObject.keyB.subKeyB: B
is provided, the agents are configured askey: "myObject"
,value: { keyA: "A", keyB: { subKeyB: "B" } }
, leading to APM reportinglabels.myObject: [object Object]
.This PR ensures the
globalLabels
object is flattened before providing it to the agents so that they apply their dot-to-underscore replacement in thekey
as declared in the docs.Checklist
For maintainers