[ML] AIOps Log Rate Analysis: Fixes text field selection #186176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-ui (:ml) |
walterra
added
the
Feature:ML/AIOps
peteharverson
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
LGTM.
Only data set I found to to test this was gallery where the useragent field no longer appears in the results.
Unrelated to the changes here, but the styling for text fields could maybe do with a tweak - padding in between the icon and the text, and the horizontal alignment is off compared to keyword fields.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @walterra |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 18, 2024
If we analyse all detected text fields, we might run into performance issues with the `categorize_text` aggregation. Until this is resolved, we will rely on a predefined white list of supported text fields, for now set to `message` and `error.message`. (cherry picked from commit d3b8123)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 18, 2024
… (#186351) # Backport This will backport the following commits from `main` to `8.14`: - [[ML] AIOps Log Rate Analysis: Fix text field selection (#186176)](#186176) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-06-18T07:49:50Z","message":"[ML] AIOps Log Rate Analysis: Fix text field selection (#186176)\n\nIf we analyse all detected text fields, we might run into performance\r\nissues with the `categorize_text` aggregation. Until this is resolved,\r\nwe will rely on a predefined white list of supported text fields, for\r\nnow set to `message` and `error.message`.","sha":"d3b81237ee3138e7a62ae34c19f65109b751f0b3","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:ML/AIOps","v8.15.0","v8.14.2"],"title":"[ML] AIOps Log Rate Analysis: Fix text field selection","number":186176,"url":"https://github.com/elastic/kibana/pull/186176","mergeCommit":{"message":"[ML] AIOps Log Rate Analysis: Fix text field selection (#186176)\n\nIf we analyse all detected text fields, we might run into performance\r\nissues with the `categorize_text` aggregation. Until this is resolved,\r\nwe will rely on a predefined white list of supported text fields, for\r\nnow set to `message` and `error.message`.","sha":"d3b81237ee3138e7a62ae34c19f65109b751f0b3"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/186176","number":186176,"mergeCommit":{"message":"[ML] AIOps Log Rate Analysis: Fix text field selection (#186176)\n\nIf we analyse all detected text fields, we might run into performance\r\nissues with the `categorize_text` aggregation. Until this is resolved,\r\nwe will rely on a predefined white list of supported text fields, for\r\nnow set to `message` and `error.message`.","sha":"d3b81237ee3138e7a62ae34c19f65109b751f0b3"}},{"branch":"8.14","label":"v8.14.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <[email protected]>
walterra
added
the
bug
szabosteve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #181111.
If we analyse all detected text fields, we might run into performance issues with the
categorize_textaggregation. Until this is resolved, we will rely on a predefined safe list of supported text fields, for now set tomessageanderror.message.Checklist
Delete any items that are not applicable to this PR.