Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v95.0.0 #185943

Merged
merged 13 commits into from
Jun 18, 2024
Merged

Upgrade EUI to v95.0.0 #185943

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
afa4817
chore: upgrade `@elastic/eui` to v95.0.0
tkajtoch Jun 11, 2024
e392d9e
build: remove deprecated `@elastic/eui/dist/eui_charts_theme` from sh…
tkajtoch Jun 11, 2024
28742a3
chore: update i18n_eui_mapping
tkajtoch Jun 11, 2024
9db17b1
test: update snapshots
tkajtoch Jun 11, 2024
c8ae9d9
feat: remove usages of unused `compressed` prop from `EuiCheckbox`
tkajtoch Jun 11, 2024
afc6fed
fix: ensure `excludeHitsFromPreviousRun` fallbacks to DEFAULT_VALUES.…
tkajtoch Jun 12, 2024
08a6586
fix: use clear selection bulk action to deselect tags
tkajtoch Jun 12, 2024
531877e
test: update fleet radio button selectors
tkajtoch Jun 13, 2024
2181962
style: reformat code
tkajtoch Jun 13, 2024
ae796e9
[Fleet] Update EuiRadioGroup wrapping to account for new Emotion styles
cee-chen Jun 13, 2024
d6bd05e
Merge branch 'main' into feat/eui-95.0.0
kibanamachine Jun 13, 2024
7119095
Merge branch 'main' into feat/eui-95.0.0
cee-chen Jun 17, 2024
cb748e7
EUI backport with unordered steps feature
cee-chen Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions examples/response_stream/public/containers/app/pages/page_reducer_stream/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,21 +132,18 @@ export const PageReducerStream: FC = () => {
label="Simulate errors (gets applied to new streams only, not currently running ones)."
checked={simulateErrors}
onChange={(e) => setSimulateErrors(!simulateErrors)}
compressed
/>
<EuiCheckbox
id="responseStreamCompressionCheckbox"
label="Toggle compression setting for response stream."
checked={compressResponse}
onChange={(e) => setCompressResponse(!compressResponse)}
compressed
/>
<EuiCheckbox
id="responseStreamFlushFixCheckbox"
label="Toggle flushFix setting for response stream."
checked={flushFix}
onChange={(e) => setFlushFix(!flushFix)}
compressed
/>
</EuiText>
</Page>
Expand Down
3 changes: 0 additions & 3 deletions examples/response_stream/public/containers/app/pages/page_redux_stream/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,21 +136,18 @@ export const PageReduxStream: FC = () => {
label="Simulate errors (gets applied to new streams only, not currently running ones)."
checked={simulateErrors}
onChange={(e) => dispatch(setSimulateErrors(!simulateErrors))}
compressed
/>
<EuiCheckbox
id="responseStreamCompressionCheckbox"
label="Toggle compression setting for response stream."
checked={compressResponse}
onChange={(e) => dispatch(setCompressResponse(!compressResponse))}
compressed
/>
<EuiCheckbox
id="responseStreamFlushFixCheckbox"
label="Toggle flushFix setting for response stream."
checked={flushFix}
onChange={(e) => dispatch(setFlushFix(!flushFix))}
compressed
/>
</EuiText>
</Page>
Expand Down
1 change: 0 additions & 1 deletion examples/response_stream/public/containers/app/pages/page_simple_string_stream/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ export const PageSimpleStringStream: FC = () => {
label="Toggle compression setting for response stream."
checked={compressResponse}
onChange={(e) => setCompressResponse(!compressResponse)}
compressed
/>
<EuiSpacer />
<EuiText>
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
"@elastic/ecs": "^8.11.1",
"@elastic/elasticsearch": "^8.13.1",
"@elastic/ems-client": "8.5.1",
"@elastic/eui": "94.6.0",
"@elastic/eui": "95.0.0",
"@elastic/filesaver": "1.1.2",
"@elastic/node-crypto": "1.2.1",
"@elastic/numeral": "^2.5.1",
Expand Down
1 change: 1 addition & 0 deletions packages/core/i18n/core-i18n-browser-internal/src/__snapshots__/i18n_service.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions packages/core/i18n/core-i18n-browser-internal/src/i18n_eui_mapping.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ export const getEuiContextMapping = (): EuiTokensObject => {
'euiBasicTable.noItemsMessage': i18n.translate('core.euiBasicTable.noItemsMessage', {
defaultMessage: 'No items found',
}),
'euiBasicTable.deselectRows': i18n.translate('core.euiBasicTable.deselectRows', {
defaultMessage: 'Deselect rows',
}),
'euiBottomBar.customScreenReaderAnnouncement': ({ landmarkHeading }: EuiValues) =>
i18n.translate('core.euiBottomBar.customScreenReaderAnnouncement', {
defaultMessage:
Expand Down
1 change: 0 additions & 1 deletion packages/kbn-ui-shared-deps-npm/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ module.exports = (_, argv) => {
'@elastic/eui/optimize/es/components/provider/nested',
'@elastic/eui/optimize/es/services',
'@elastic/eui/optimize/es/services/format',
'@elastic/eui/dist/eui_charts_theme',
'@elastic/eui/dist/eui_theme_light.json',
'@elastic/eui/dist/eui_theme_dark.json',
'@elastic/numeral',
Expand Down
1 change: 0 additions & 1 deletion packages/kbn-ui-shared-deps-src/src/definitions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ const externals = {
'__kbnSharedDeps__.ElasticEuiLibComponentsUseIsNestedEuiProvider',
'@elastic/eui/lib/services': '__kbnSharedDeps__.ElasticEuiLibServices',
'@elastic/eui/lib/services/format': '__kbnSharedDeps__.ElasticEuiLibServicesFormat',
'@elastic/eui/dist/eui_charts_theme': '__kbnSharedDeps__.ElasticEuiChartsTheme',

// transient dep of eui
'@hello-pangea/dnd': '__kbnSharedDeps__.HelloPangeaDnd',
Expand Down
1 change: 0 additions & 1 deletion packages/kbn-ui-shared-deps-src/src/entry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ export const ElasticEui = require('@elastic/eui');
export const ElasticEuiLibComponentsUseIsNestedEuiProvider = require('@elastic/eui/optimize/es/components/provider/nested');
export const ElasticEuiLibServices = require('@elastic/eui/optimize/es/services');
export const ElasticEuiLibServicesFormat = require('@elastic/eui/optimize/es/services/format');
export const ElasticEuiChartsTheme = require('@elastic/eui/dist/eui_charts_theme');
export const KbnDatemath = require('@kbn/datemath');
export const HelloPangeaDnd = require('@hello-pangea/dnd/dist/dnd');
export const ReduxjsToolkit = require('@reduxjs/toolkit');
Expand Down
2 changes: 1 addition & 1 deletion src/dev/license_checker/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export const LICENSE_OVERRIDES = {
'[email protected]': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts
'@mapbox/[email protected]': ['MIT'], // license in readme https://github.com/tmcw/jsonlint
'@elastic/[email protected]': ['Elastic License 2.0'],
'@elastic/eui@94.6.0': ['SSPL-1.0 OR Elastic License 2.0'],
'@elastic/eui@95.0.0': ['SSPL-1.0 OR Elastic License 2.0'],
'[email protected]': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry
'[email protected]': ['MIT'], // license in importing module https://www.npmjs.com/package/binary
'@bufbuild/[email protected]': ['Apache-2.0'], // license (Apache-2.0 AND BSD-3-Clause)
Expand Down
1 change: 0 additions & 1 deletion src/plugins/controls/public/control_group/component/control_group_component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ export const ControlGroup = () => {
content={ControlGroupStrings.invalidControlWarning.getTourContent(invalidControlType)}
footerAction={[
<EuiCheckbox
compressed
checked={suppressTourChecked}
id={'controlGroup--suppressTourCheckbox'}
className="controlGroup--suppressTourCheckbox"
Expand Down
1 change: 0 additions & 1 deletion ...impl/assistant/prompt_editor/system_prompt/system_prompt_modal/system_prompt_settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,6 @@ export const SystemPromptSettings: React.FC<Props> = React.memo(
}
checked={isNewConversationDefault}
onChange={handleNewConversationDefaultChange}
compressed
/>
</EuiFormRow>
</>
Expand Down
1 change: 0 additions & 1 deletion ...ns/app_search/components/documents/search_experience/views/multi_checkbox_facets_view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ export const MultiCheckboxFacetsView: React.FC<Props> = ({
options={checkboxGroupOptions}
idToSelectedMap={idToSelectedMap}
onChange={onChange}
compressed
/>
{showMore && (
<>
Expand Down
20 changes: 11 additions & 9 deletions x-pack/plugins/fleet/cypress/e2e/fleet_settings_outputs.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ queue:
});

// Verify SSL fields
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_SSL_OPTION).click();
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_SSL_OPTION).find('label').click();
cy.get('[placeholder="Specify certificate authority"]');
cy.get('[placeholder="Specify ssl certificate"]');
cy.get('[placeholder="Specify certificate key"]');
Expand All @@ -292,7 +292,7 @@ queue:

// Verify None fields

cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_NONE_OPTION).click();
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_NONE_OPTION).find('label').click();

cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_SASL_SELECT).should('not.exist');
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_USERNAME_INPUT).should('not.exist');
Expand All @@ -308,14 +308,16 @@ queue:
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_CONNECTION_TYPE_PLAIN_OPTION);
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_CONNECTION_TYPE_ENCRYPTION_OPTION);

cy.getBySel(
SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_CONNECTION_TYPE_ENCRYPTION_OPTION
).click();
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_CONNECTION_TYPE_ENCRYPTION_OPTION)
.find('label')
.click();

cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_VERIFICATION_MODE_INPUT);
cy.get('[placeholder="Specify certificate authority"]');

cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_USERNAME_PASSWORD_OPTION).click();
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_USERNAME_PASSWORD_OPTION)
.find('label')
.click();

// Verify Partitioning fields
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.PARTITIONING_PANEL).within(() => {
Expand All @@ -327,13 +329,13 @@ queue:
});

// Verify Round Robin fields
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.PARTITIONING_RANDOM_OPTION).click();
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.PARTITIONING_RANDOM_OPTION).find('label').click();
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.PARTITIONING_EVENTS_INPUT);

// Verify Hash fields
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.PARTITIONING_HASH_OPTION).click();
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.PARTITIONING_HASH_OPTION).find('label').click();
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.PARTITIONING_HASH_INPUT);
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.PARTITIONING_RANDOM_OPTION).click();
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.PARTITIONING_RANDOM_OPTION).find('label').click();

// Topics
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.TOPICS_PANEL).within(() => {
Expand Down
8 changes: 4 additions & 4 deletions x-pack/plugins/fleet/cypress/screens/fleet_outputs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const selectKafkaOutput = () => {
visit('/app/fleet/settings');
cy.getBySel(SETTINGS_OUTPUTS.ADD_BTN).click();
cy.getBySel(SETTINGS_OUTPUTS.TYPE_INPUT).select('kafka');
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_USERNAME_PASSWORD_OPTION).click();
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_USERNAME_PASSWORD_OPTION).find('label').click();
};

export const shouldDisplayError = (handler: string) => {
Expand Down Expand Up @@ -190,8 +190,8 @@ export const fillInKafkaOutputForm = (create?: boolean) => {
);
cy.get('[placeholder="Specify certificate authority"]').clear().type('testCA');

cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_SASL_SCRAM_256_OPTION).click();
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.PARTITIONING_HASH_OPTION).click();
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_SASL_SCRAM_256_OPTION).find('label').click();
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.PARTITIONING_HASH_OPTION).find('label').click();

cy.getBySel(kafkaOutputFormValues.hash.selector).type(kafkaOutputFormValues.hash.value);
cy.getBySel(kafkaOutputFormValues.defaultTopic.selector).type(
Expand Down Expand Up @@ -265,7 +265,7 @@ export const validateOutputTypeChangeToKafka = (outputId: string) => {
visit(`/app/fleet/settings/outputs/${outputId}`);
cy.getBySel(kafkaOutputFormValues.name.selector).clear();
cy.getBySel(SETTINGS_OUTPUTS.TYPE_INPUT).select('kafka');
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_USERNAME_PASSWORD_OPTION).click();
cy.getBySel(SETTINGS_OUTPUTS_KAFKA.AUTHENTICATION_USERNAME_PASSWORD_OPTION).find('label').click();

fillInKafkaOutputForm(true);
cy.intercept('PUT', '**/api/fleet/outputs/**').as('saveOutput');
Expand Down
2 changes: 1 addition & 1 deletion .../fleet/sections/settings/components/edit_output_flyout/output_form_kafka_partitioning.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export const OutputFormKafkaPartitioning: React.FunctionComponent<{
}
>
<EuiRadioGroup
style={{ display: 'flex', gap: 30 }}
style={{ flexDirection: 'row', flexWrap: 'wrap', columnGap: 30 }}
data-test-subj={'settingsOutputsFlyout.kafkaPartitioningRadioInput'}
options={kafkaPartitioningOptions}
compressed
Expand Down
1 change: 0 additions & 1 deletion ...t/public/applications/integrations/sections/epm/screens/detail/settings/update_button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ export const UpdateButton: React.FunctionComponent<UpdateButtonProps> = ({
{packagePolicyCount > 0 && (
<EuiFlexItem grow={false}>
<EuiCheckbox
compressed
labelProps={{
style: {
display: 'flex',
Expand Down
18 changes: 0 additions & 18 deletions ...s/ml/public/application/components/rule_editor/__snapshots__/actions_section.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions ...l/public/application/components/rule_editor/__snapshots__/rule_editor_flyout.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 0 additions & 12 deletions .../ml/public/application/components/rule_editor/__snapshots__/scope_expression.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading